Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Do not trigger extra guards#31584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromlyrixx:workflow-apply-optim
May 27, 2019

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedMay 22, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31582
LicenseMIT
Doc PR

With this patch, guards are executed only on wanted transitions

Note for merger: This is already fixed (in a different manner) in 4.2, So this patch should not be included in 4.2, instead take:#31585 or discard changes of Workflow class but keep tests

noniagriconomie reacted with hooray emoji
@lyrixxlyrixxforce-pushed theworkflow-apply-optim branch 2 times, most recently fromd0eb9df to72cec55CompareMay 22, 2019 15:31
@lyrixxlyrixx changed the title[Workflow] Do not trigger extra guard[Workflow] Do not trigger extra guardsMay 22, 2019
@noniagriconomie
Copy link
Contributor

@lyrixx thank you so much!

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneMay 22, 2019
@lyrixxlyrixxforce-pushed theworkflow-apply-optim branch from72cec55 to07c7fa8CompareMay 24, 2019 14:53
With this patch, guard are executed only on wanted transitions
@lyrixxlyrixxforce-pushed theworkflow-apply-optim branch from07c7fa8 toad06197CompareMay 26, 2019 14:07
@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commitad06197 intosymfony:3.4May 27, 2019
fabpot added a commit that referenced this pull requestMay 27, 2019
This PR was merged into the 3.4 branch.Discussion----------[Workflow] Do not trigger extra guards| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#31582| License       | MIT| Doc PR        |---With this patch, guards are executed only on wanted transitions**Note for merger**: This is already fixed (in a different manner) in 4.2, So this patch should not be included in 4.2, instead take:#31585 or discard changes of Workflow class but keep testsCommits-------ad06197 [Workflow] Do not trigger extra guard
@lyrixxlyrixx deleted the workflow-apply-optim branchMay 27, 2019 15:40
This was referencedMay 28, 2019
@rumours86
Copy link

rumours86 commentedMay 29, 2019•
edited
Loading

Note for merger: This is already fixed (in a different manner) in 4.2, So this patch should not be included in 4.2, instead take:#31585 or discard changes of Workflow class but keep tests

Release v4.2.9#31651 Merged

this patch should not be included in 4.2 !!

@lyrixx
Copy link
MemberAuthor

@rumours86 Don't worry, I checked few days ago and everything was fine.

rumours86 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@noniagriconomienoniagriconomienoniagriconomie left review comments

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@lyrixx@noniagriconomie@fabpot@rumours86@Simperfit@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp