NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HTTP2 if defined#31569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.3fromGwendolenLynch:http-client-curl

May 22, 2019

Merged

[HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HTTP2 if defined#31569

fabpot merged 1 commit intosymfony:4.3fromGwendolenLynch:http-client-curl

May 22, 2019

Conversation

Copy link

Contributor

GwendolenLynch commentedMay 22, 2019•
edited
Loading

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Regards the constants:

CURLMOPT_MAX_HOST_CONNECTIONS is available since PHP 7.0.7 and cURL 7.30.0
CURL_VERSION_HTTP2 is available since PHP 5.5.24 and 5.6.8 and cURL 7.33.0

Errors triggered:

Use of undefined constant CURLMOPT_MAX_HOST_CONNECTIONS - assumed 'CURLMOPT_MAX_HOST_CONNECTIONS'
in vendor/symfony/http-client/CurlHttpClient.php (line 73)

Use of undefined constant CURL_VERSION_HTTP2 - assumed 'CURL_VERSION_HTTP2'
in vendor/symfony/http-client/CurlHttpClient.php (line 191)

[HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HT…

4ea7283

…TP2 if defined - CURLMOPT_MAX_HOST_CONNECTIONS is available since PHP 7.0.7 and cURL 7.30.0 - CURL_VERSION_HTTP2 is available since PHP 5.5.24 and 5.6.8 and cURL 7.33.0

carsonbot added Status: Needs Review Bug labels

May 22, 2019

fabpot approved these changes

May 22, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

May 22, 2019

nicolas-grekas approved these changes

May 22, 2019

View reviewed changes

Copy link

Member

fabpot commentedMay 22, 2019

Thank you @GawainLynch.

fabpot merged commit4ea7283 intosymfony:4.3

May 22, 2019

fabpot added a commit that referenced this pull request

May 22, 2019

bug#31569[HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL…

274ff66

…_VERSION_HTTP2 if defined (GawainLynch)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HTTP2 if defined| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Regards the constants: - CURLMOPT_MAX_HOST_CONNECTIONS is available since PHP 7.0.7 and cURL 7.30.0 - CURL_VERSION_HTTP2 is available since PHP 5.5.24 and 5.6.8 and cURL 7.33.0Errors triggered:> Use of undefined constant CURLMOPT_MAX_HOST_CONNECTIONS - assumed 'CURLMOPT_MAX_HOST_CONNECTIONS'> in vendor/symfony/http-client/CurlHttpClient.php (line 73)> Use of undefined constant CURL_VERSION_HTTP2 - assumed 'CURL_VERSION_HTTP2'> in vendor/symfony/http-client/CurlHttpClient.php (line 191)Commits-------4ea7283 [HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HTTP2 if defined