Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] use method marking store#31537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromnoniagriconomie:patch-2
May 20, 2019

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedMay 18, 2019•
edited by lyrixx
Loading

QA
Branch?4.3 (related to deprecation of single/multiple marking store)
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets.
LicenseMIT
Doc PRalready documented

I think the deprecation of old marking store, the single one in the statemachine, was not patched here
Or did i miss something?

Thank you

Cc@lyrixx

@lyrixx
Copy link
Member

Could you look at the CI?

@noniagriconomie
Copy link
ContributorAuthor

@lyrixx PR desc update accordingly
unsure about theNew feature? andDeprecations? however

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

unsure about the New feature? and Deprecations? however

I have fixed it for you :)

Thanks for your PR 👍

@nicolas-grekas
Copy link
Member

Thank you@noniagriconomie.

@nicolas-grekasnicolas-grekas merged commita219167 intosymfony:4.3May 20, 2019
nicolas-grekas added a commit that referenced this pull requestMay 20, 2019
This PR was merged into the 4.3 branch.Discussion----------[Workflow] use method marking store| Q             | A| ------------- | ---| Branch?       | 4.3 (related to deprecation of single/multiple marking store)| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | .| License       | MIT| Doc PR        | already documentedI think the deprecation of old marking store, the single one in the statemachine, was not patched hereOr did i miss something?Thank youCc@lyrixxCommits-------a219167 [Workflow] use method marking store
@noniagriconomienoniagriconomie deleted the patch-2 branchMay 20, 2019 12:20
@fabpotfabpot mentioned this pull requestMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxlyrixx approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@noniagriconomie@lyrixx@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp