Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Debug] Wrap call to require_once in a try/catch#31535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromlyrixx:debug-class-loader
May 18, 2019

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedMay 18, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketssymfony/monolog-bundle#236
LicenseMIT
Doc PR

If the included file contains an error, it hides the real error. This
makes debugging harder.

How to reproduce:

composer create-project symfony/skeleton symfony-3.4 3.4cd symfony-3.4composer req monolog

Add tomonolog.yaml:

elasticsearch:type:"elasticsearch"elasticsearch:host:'elasticsearch'port:'9200'index:'ep_php_logs_dev'level:'debug'tags:'monolog.logger'channels:['!event']

This will fail because the the\Elastica\Client class does not exist.
But this error will be hidden by theClassNotFoundFatalErrorHandler
because it will try to load theSymfony\Component\Kernel\Client and
this class extendsSymfony\Component\BrowserKit\Client. The last one
is a soft dependency...


Before

Fatal error: Uncaught Error: Class 'Symfony\Component\BrowserKit\Client' not found in /tmp/symfony-3.4/vendor/symfony/http-kernel/Client.php:31

After:

Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "Client" from namespace "Elastica".Did you forget a "use" statement for another namespace? in /tmp/symfony-es/var/cache/dev/ContainerWXN4mS9/srcApp_KernelDevDebugContainer.php:303

If the included file contains an error, it hides the real error. Thismakes debugging harder.How to reproduce:```composer create-project symfony/skeleton symfony-3.4 3.4cd symfony-3.4composer req monolog```Add to `monolog.yaml`:```yaml        elasticsearch:            type: "elasticsearch"            elasticsearch:                host: 'elasticsearch'                port: '9200'            index: 'ep_php_logs_dev'            level: 'debug'            tags: 'monolog.logger'            channels: ['!event']```This will fail because the the \Elastica\Client class does not exist.But this error will be hidden by the `ClassNotFoundFatalErrorHandler`because it will try to load the `Symfony\Component\Kernel\Client` andthis class extends `Symfony\Component\BrowserKit\Client`. The last oneis a soft dependency...---Before```Fatal error: Uncaught Error: Class 'Symfony\Component\BrowserKit\Client' not found in /tmp/symfony-3.4/vendor/symfony/http-kernel/Client.php:31```After:```Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "Client" from namespace "Elastica".Did you forget a "use" statement for another namespace? in /tmp/symfony-es/var/cache/dev/ContainerWXN4mS9/srcApp_KernelDevDebugContainer.php:303```
@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commitafb6e1e intosymfony:3.4May 18, 2019
fabpot added a commit that referenced this pull requestMay 18, 2019
This PR was merged into the 3.4 branch.Discussion----------[Debug] Wrap call to require_once in a try/catch| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony/monolog-bundle#236| License       | MIT| Doc PR        |If the included file contains an error, it hides the real error. Thismakes debugging harder.How to reproduce:```composer create-project symfony/skeleton symfony-3.4 3.4cd symfony-3.4composer req monolog```Add to `monolog.yaml`:```yaml        elasticsearch:            type: "elasticsearch"            elasticsearch:                host: 'elasticsearch'                port: '9200'            index: 'ep_php_logs_dev'            level: 'debug'            tags: 'monolog.logger'            channels: ['!event']```This will fail because the the `\Elastica\Client` class does not exist.But this error will be hidden by the `ClassNotFoundFatalErrorHandler`because it will try to load the `Symfony\Component\Kernel\Client` andthis class extends `Symfony\Component\BrowserKit\Client`. The last oneis a soft dependency...---Before```Fatal error: Uncaught Error: Class 'Symfony\Component\BrowserKit\Client' not found in /tmp/symfony-3.4/vendor/symfony/http-kernel/Client.php:31```After:```Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "Client" from namespace "Elastica".Did you forget a "use" statement for another namespace? in /tmp/symfony-es/var/cache/dev/ContainerWXN4mS9/srcApp_KernelDevDebugContainer.php:303```<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------afb6e1e [Debug] Wrap call to require_once in a try/catch
@lyrixxlyrixx deleted the debug-class-loader branchMay 18, 2019 20:10
This was referencedMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lyrixx@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp