Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use the current working dir as default first arg in 'link' binary#31510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromlyrixx:link
May 18, 2019

Conversation

@lyrixx
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

I don't know how you work on symfony, but each time I face the same issue

  1. I go on lyrixx/symfony (my fork)
  2. I executepwd and copy it
  3. I go to an application
  4. I paste the cwd + add/link and hit enter
  5. I got an error because I missed the "target"
  6. I replay the last command and add .

With this PR, I will save the last 2 items...

Event if it's a "new feature", I targeted 3.4.

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think 3.4 is fine

@ro0NL
Copy link
Contributor

ro0NL commentedMay 16, 2019•
edited
Loading

I don't know how you work on symfony

  1. goto my project
  2. goto my fork;cd var/sf-src
  3. link ../..
  4. optionally go back to project;cd -

i think this change is fine. Perhaps check if we execlink in the symfony clone, then using the current working dir is unexpected, as it will link to itself (at least this part changes)

edit: not sure we have to care about that actually

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit6b76c36 intosymfony:3.4May 18, 2019
fabpot added a commit that referenced this pull requestMay 18, 2019
… binary (lyrixx)This PR was merged into the 3.4 branch.Discussion----------Use the current working dir as default first arg in 'link' binary| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |I don't know how you work on symfony, but each time I face the same issue1. I go on lyrixx/symfony (my fork)1. I execute `pwd` and copy it1. I go to an application1. I paste the cwd + add `/link` and hit enter1. I got an error because I missed the "target"1. I replay the last command and add ` .`With this PR, I will save the last 2 items...Event if it's a "new feature", I targeted 3.4.Commits-------6b76c36 Use the current working dir as default first arg in 'link' binary
@lyrixxlyrixx deleted the link branchMay 18, 2019 20:15
This was referencedMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lyrixx@ro0NL@fabpot@nicolas-grekas@yceruto@Simperfit@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp