Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle][Form] The form data collector return serialized data#31502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedMay 15, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31476
LicenseMIT
Doc PRnot needed

This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.

This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.

@fabpot
Copy link
Member

What about fixing the constraints between the Form component and WebProfileBundle instead?

@Simperfit
Copy link
ContributorAuthor

@fabpot What will happen on the existing application requiring already theses versions (so with the bug) ?

@fabpot
Copy link
Member

The bug will still be there I suppose... but that's the same with your fix... you need to update to get it. I prefer to avoid having too many specific code to support different versions, bumping min versions is usually what we do.

Simperfit reacted with thumbs up emoji

@xabbuh
Copy link
Member

What is the version we would have to require to not have to use this code?

@Simperfit
Copy link
ContributorAuthor

Simperfit commentedMay 15, 2019
edited
Loading

That's what I'm looking into, need to search@xabbuh

@SimperfitSimperfitforce-pushed thebugfix/form-collector-return-serialized-data branch from04c86fa tof04f415CompareMay 15, 2019 18:21
@Simperfit
Copy link
ContributorAuthor

Simperfit commentedMay 15, 2019
edited
Loading

@fabpot I've added a conflict in the WebProfilerBundle to avoid using the Form component below 4.3 since there are no real dependencies between the two, WDYT ?

@SimperfitSimperfitforce-pushed thebugfix/form-collector-return-serialized-data branch fromf04f415 to70fdafdCompareMay 15, 2019 18:23
@SimperfitSimperfit changed the base branch from3.4 to4.3May 15, 2019 18:23
@xabbuhxabbuh added this to the4.3 milestoneMay 15, 2019
@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit70fdafd intosymfony:4.3May 18, 2019
fabpot added a commit that referenced this pull requestMay 18, 2019
…erialized data (Simperfit)This PR was merged into the 4.3 branch.Discussion----------[WebProfilerBundle][Form] The form data collector return serialized data| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#31476 <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | not needed <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.Commits-------70fdafd [WebProfilerBundle][Form] The form data collector return serialized object when profiler bundle attends object
@fabpotfabpot mentioned this pull requestMay 22, 2019
@j4nr6n
Copy link
Contributor

Thanks for the fix@Simperfit

Simperfit reacted with thumbs up emoji

@SimperfitSimperfit deleted the bugfix/form-collector-return-serialized-data branchJune 19, 2019 06:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@Simperfit@fabpot@xabbuh@j4nr6n@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp