Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle][Form] The form data collector return serialized data#31502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[WebProfilerBundle][Form] The form data collector return serialized data#31502
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedMay 15, 2019
What about fixing the constraints between the Form component and WebProfileBundle instead? |
Simperfit commentedMay 15, 2019
@fabpot What will happen on the existing application requiring already theses versions (so with the bug) ? |
fabpot commentedMay 15, 2019
The bug will still be there I suppose... but that's the same with your fix... you need to update to get it. I prefer to avoid having too many specific code to support different versions, bumping min versions is usually what we do. |
xabbuh commentedMay 15, 2019
What is the version we would have to require to not have to use this code? |
Simperfit commentedMay 15, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That's what I'm looking into, need to search@xabbuh |
04c86fa tof04f415CompareSimperfit commentedMay 15, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fabpot I've added a conflict in the WebProfilerBundle to avoid using the Form component below 4.3 since there are no real dependencies between the two, WDYT ? |
…bject when profiler bundle attends object
f04f415 to70fdafdComparefabpot commentedMay 18, 2019
Thank you@Simperfit. |
…erialized data (Simperfit)This PR was merged into the 4.3 branch.Discussion----------[WebProfilerBundle][Form] The form data collector return serialized data| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#31476 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | not needed <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.Commits-------70fdafd [WebProfilerBundle][Form] The form data collector return serialized object when profiler bundle attends object
j4nr6n commentedJun 18, 2019
Thanks for the fix@Simperfit |
Uh oh!
There was an error while loading.Please reload this page.
This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.
This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.