Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Autovalidation: skip readonly props#31481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromdunglas:fix-autovalid-ro
May 13, 2019

Conversation

@dunglas
Copy link
Member

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

Read-only properties (such as an autogenerated ID) must be skipped during the validation (it makes no sense to validate a RO property anyway).
This is an allowed BC break because this feature will be introduced in 4.3.

@fabpot
Copy link
Member

Thank you@dunglas.

@fabpotfabpot merged commite7dc5e1 intosymfony:4.3May 13, 2019
fabpot added a commit that referenced this pull requestMay 13, 2019
This PR was merged into the 4.3 branch.Discussion----------[Validator] Autovalidation: skip readonly props| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aRead-only properties (such as an autogenerated ID) must be skipped during the validation (it makes no sense to validate a RO property anyway).This is an allowed BC break because this feature will be introduced in 4.3.Commits-------e7dc5e1 [Validator] Autovalidation: skip readonly props
fabpot added a commit that referenced this pull requestMay 13, 2019
… (dunglas)This PR was merged into the 4.3 branch.Discussion----------[Doctrine][PropertyInfo] Detect if the ID is writeable| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aCompanion of#31481. Allows to detect that ids with a generated value aren't writable (because the DBMS will generate the ID by itself). It could be considered as a bug fix or as a new feature. I prefer to not merge in in 3.4. However, it becomes necessary for autovalidation to work with such entities, so it should be in 4.3:```php/** *@entity */class Foo{    /**     *@id     * @GeneratedValue(strategy="AUTO")     *@column(type="integer")     */    public $id;}```Commits-------4598235 [Doctrine][PropertyInfo] Detect if the ID is writeable
@fabpotfabpot mentioned this pull requestMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+2 more reviewers

@srozesrozesroze left review comments

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@dunglas@fabpot@nicolas-grekas@sroze@maxhelias@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp