Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update dependencies in the main component#31480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromDavidPrevot:dep
May 13, 2019
Merged

Conversation

@DavidPrevot
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PR

The doctrine/collections and psr/simple-cache dependencies have already been demoted to require-dev in the relevant components.

BTW, I wonder if symfony/mailer (and symfony/*-mailer bridges) should be provided in the main composer.json too.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedMay 12, 2019
edited
Loading

Thanks, good catch.
For mailer I think it would make sense to list it.
For the bridges I think we prefer keeping them separate.

@nicolas-grekas
Copy link
Member

Thinking twice, bridges should be in the replace section too, so that flex can apply its extra.symfony.require constraints on them!

@DavidPrevot
Copy link
ContributorAuthor

Updated according to@nicolas-grekas advice, thanks.

@fabpot
Copy link
Member

Thank you@DavidPrevot.

@fabpotfabpot merged commit96f4626 intosymfony:4.3May 13, 2019
fabpot added a commit that referenced this pull requestMay 13, 2019
This PR was squashed before being merged into the 4.3 branch (closes#31480).Discussion----------Update dependencies in the main component| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        |The doctrine/collections and psr/simple-cache dependencies have already been demoted to require-dev in the relevant components.BTW, I wonder if symfony/mailer (and symfony/*-mailer bridges) should be provided in the main composer.json too.Commits-------96f4626 Update dependencies in the main component
@fabpotfabpot mentioned this pull requestMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidPrevot@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp