Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix routable message bus default bus#31472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
917d72c to42e0536CompareTobion approved these changesMay 11, 2019
Contributor
Tobion commentedMay 11, 2019
Thanks for fixing this bug@weaverryan. |
Tobion added a commit that referenced this pull requestMay 11, 2019
This PR was merged into the 4.3 branch.Discussion----------[Messenger] Fix routable message bus default bus| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | not neededIn#31288, we gave the `RoutableMessageBus` a "default" bus. We did that by using the `MessageBusInterface` service in the locator. But, no such service exists - I think that was just a huge oversight (and maybe@dirk39 named a bus this in the project he was testing on?). The services in the locator are very simply the keys under `framework.messenger.buses` or the default, which is a single `messenger.bus.default` id. There is an alias in the container for `MessageBusInterface`, but this is not added to the locator (and adding it would be a bit awkward, as `MessengerPass` is in the component and the interface alias is entirely a framework thing).Cheers!Commits-------42e0536 Changing how RoutableMessageBus fallback bus works
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In#31288, we gave the
RoutableMessageBusa "default" bus. We did that by using theMessageBusInterfaceservice in the locator. But, no such service exists - I think that was just a huge oversight (and maybe@dirk39 named a bus this in the project he was testing on?). The services in the locator are very simply the keys underframework.messenger.busesor the default, which is a singlemessenger.bus.defaultid. There is an alias in the container forMessageBusInterface, but this is not added to the locator (and adding it would be a bit awkward, asMessengerPassis in the component and the interface alias is entirely a framework thing).Cheers!