Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix the interface incompatibility of EventDispatchers#31459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The `LegacyEventDispatcherProxy` now implements the full`EventDispatcherInterface` from the `EventDispatcherBundle`.Before it just implemented the Interface from the `Contracts` Bundle,that made it incompatible with the `WrappedListener`.Thisfixessymfony#31457.
fabpot approved these changesMay 13, 2019
Member
fabpot commentedMay 13, 2019
Thank you@keulinho. |
fabpot added a commit that referenced this pull requestMay 13, 2019
…linho)This PR was merged into the 4.3 branch.Discussion----------Fix the interface incompatibility of EventDispatchersThe `LegacyEventDispatcherProxy` now implements the full`EventDispatcherInterface` from the `EventDispatcherBundle`.Before it just implemented the Interface from the `Contracts` Bundle,that made it incompatible with the `WrappedListener`.Thisfixes#31457.| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31457| License | MIT| Doc PR | /Commits-------bdeeae1 Fix the interface incompatibility of EventDispatchers
fabpot added a commit that referenced this pull requestMay 15, 2019
…ges (chalasr)This PR was merged into the 4.3 branch.Discussion----------[EventDispatcher] Fix interface name used in error messages| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Forgotten in#31459Commits-------38cad41 [EventDispatcher] Fix interface name used in error messages
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LegacyEventDispatcherProxynow implements the fullEventDispatcherInterfacefrom theEventDispatcherBundle.Before it just implemented the Interface from the
ContractsBundle,that made it incompatible with the
WrappedListener.Thisfixes#31457.