Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] remove send_and_handle which can be achieved with SyncTransport#31454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9006497 to82736bdCompare
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need an entry for the BC break in the CHANGELOG.
Thesend_and_handle solved a real problem, but it was messy. With theSyncTransport, we can remove this. It's also much more clear how the transport-based handler config (from_transport) will work when using thesync transport vs thissend_and_handle.
82736bd to4552b7fCompareTobion commentedMay 11, 2019
Added the changelogs. |
fabpot commentedMay 11, 2019
Thank you@Tobion. |
…ed with SyncTransport (Tobion)This PR was merged into the 4.3 branch.Discussion----------[Messenger] remove send_and_handle which can be achieved with SyncTransport| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#11236The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from#30759So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp] send_and_handle: true```is the same as```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp, sync]```#31401 (review)Commits-------4552b7f [Messenger] remove send_and_handle option which can be achieved with SyncTransport
sroze commentedMay 12, 2019
Fab', thank you@Tobion! |
Uh oh!
There was an error while loading.Please reload this page.
The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from#30759
So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing
is the same as
#31401 (review)