Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] remove send_and_handle which can be achieved with SyncTransport#31454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromTobion:messenger-remove-send-handle
May 11, 2019

Conversation

@Tobion
Copy link
Contributor

@TobionTobion commentedMay 10, 2019
edited
Loading

QA
Branch?4.3
Bug fix?no
New feature?yes/no
BC breaks?yes
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PRsymfony/symfony-docs#11236

The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from#30759

So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing

framework:messenger:routing:'My\Message\ThatIsGoingToBeSentAndHandledLocally':senders:[amqp]send_and_handle:true

is the same as

framework:messenger:routing:'My\Message\ThatIsGoingToBeSentAndHandledLocally':senders:[amqp, sync]

#31401 (review)

Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Need an entry for the BC break in the CHANGELOG.

Thesend_and_handle solved a real problem, but it was messy. With theSyncTransport, we can remove this. It's also much more clear how the transport-based handler config (from_transport) will work when using thesync transport vs thissend_and_handle.

@Tobion
Copy link
ContributorAuthor

Added the changelogs.

@fabpot
Copy link
Member

Thank you@Tobion.

@fabpotfabpot merged commit4552b7f intosymfony:4.3May 11, 2019
fabpot added a commit that referenced this pull requestMay 11, 2019
…ed with SyncTransport (Tobion)This PR was merged into the 4.3 branch.Discussion----------[Messenger] remove send_and_handle which can be achieved with SyncTransport| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | no| New feature?  | yes/no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | yes     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |symfony/symfony-docs#11236The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from#30759So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing```yamlframework:    messenger:        routing:            'My\Message\ThatIsGoingToBeSentAndHandledLocally':                 senders: [amqp]                 send_and_handle: true```is the same as```yamlframework:    messenger:        routing:            'My\Message\ThatIsGoingToBeSentAndHandledLocally':                 senders: [amqp, sync]```#31401 (review)Commits-------4552b7f [Messenger] remove send_and_handle option which can be achieved with SyncTransport
@TobionTobion deleted the messenger-remove-send-handle branchMay 11, 2019 07:14
@sroze
Copy link
Contributor

Fab', thank you@Tobion!

@fabpotfabpot mentioned this pull requestMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@weaverryanweaverryanweaverryan approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tobion@fabpot@sroze@weaverryan@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp