Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Making cache rebuild correctly when message subscribers change#31445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Making cache rebuild correctly when message subscribers change#31445
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Config/Resource/ReflectionClassResource.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
2355715 tod88446bCompare| class TestMessageSubscriberConfigHolder | ||
| { | ||
| publicstatic$handledMessages = []; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I discovered thattestEventSubscriber() andtestServiceSubscriber() are invalid. Part of the signature ofReflectionClassResource is the constants and their values. So, to purely test that the resource becomes stale when a static method is called, we must do thatwithout modifying any constants.
Those other 2 methods need to be fixed in 3.4 - you can comment out the code inReflectionClassResource for each and they still pass.
nicolas-grekas commentedMay 11, 2019
Good catch, thanks@weaverryan. |
…bscribers change (weaverryan)This PR was merged into the 4.2 branch.Discussion----------[Messenger] Making cache rebuild correctly when message subscribers change| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31409| License | MIT| Doc PR | not neededAn edge-case that's identical to `EventSubscriberInterface`: when the return value of `getHandledMessages()` changes, the container needs to be rebuilt.If you're wondering why these checks aren't in their own resource class, see#25984 - it's something we probably should do, but haven't done yet.Commits-------d88446b Making cache rebuild correctly with MessageSubscriberInterface return values
An edge-case that's identical to
EventSubscriberInterface: when the return value ofgetHandledMessages()changes, the container needs to be rebuilt.If you're wondering why these checks aren't in their own resource class, see#25984 - it's something we probably should do, but haven't done yet.