Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Revise timezone name generation#31434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "America\/Monterrey":"Central Time (Monterrey)", | ||
| "America\/Montevideo":"Uruguay Time (Montevideo)", | ||
| "America\/Montreal":"Canada (Montreal)", | ||
| "America\/Montreal":"CanadaTime(Montreal)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use theregionFormat for country-based names, this is much more consistent with explicitly translated zones, e.g.Coordinated Universal Time andCentral European Time
| "Indian\/Mayotte":"heure d’Afrique orientale (Mayotte)", | ||
| "Indian\/Reunion":"heure de la Réunion", | ||
| "PST8PDT":"heure du Pacifique", | ||
| "Pacific\/Easter":"heure de l’île de Pâques", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
here's the bugfix; this should be inherited fromfr locale
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "Version":"2.1.49.82", | |||
| "Meta": { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
root metadata is now compiled into root.json, in order to de-duplicte locale metadata
| "Names": { | ||
| "Africa\/Kigali":"U Rwanda (Kigali)", | ||
| "Antarctica\/Troll":"Troll", | ||
| "CST6CDT":"CST6CDT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we should never provide zone IDs as translations, in this case the runtime fallback should apply instead.
| { | ||
| "Version":"2.1.47.86", | ||
| "Names": { | ||
| "Africa\/Abidjan":"格林尼治标准时间（阿比贊）", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
only alias locales are deleted (related to#31411)
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedMay 8, 2019
Can you rebase to get green tests? |
nicolas-grekas commentedMay 9, 2019
Ready for rebase on 4.3. |
ro0NL commentedMay 9, 2019
Done. (failures unrelated) |
nicolas-grekas commentedMay 9, 2019
Thank you@ro0NL. |
This PR was merged into the 4.3 branch.Discussion---------- [Intl] Revise timezone name generation| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes (inlcluding intl-data group)| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->This is the final polishing needed for#31294 :)I've realized it's much easier to de-duplicate by processing fallback locales separate, and then only keep the diff compared to a specific locale. More or less the same approach `LocaleDataGenerator` already follows. I was trying to be clever and filter based on inheritance in a single process; bad idea.Includesro0NL@31591d0 (ref#31432)Commits-------bfdb4ed [Intl] Revise timezone name generation
…mezoneType (ro0NL)This PR was merged into the 4.3 branch.Discussion----------[Form] Add intl/choice_translation_locale option to TimezoneType| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#28836| License | MIT| Doc PR |symfony/symfony-docs#11503final step :)for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see#31293 +#31295having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future.includes#31434Commits-------001b930 [Form] Add intl/choice_translation_locale option to TimezoneType
Uh oh!
There was an error while loading.Please reload this page.
This is the final polishing needed for#31294 :)
I've realized it's much easier to de-duplicate by processing fallback locales separate, and then only keep the diff compared to a specific locale. More or less the same approach
LocaleDataGeneratoralready follows. I was trying to be clever and filter based on inheritance in a single process; bad idea.Includesro0NL@31591d0 (ref#31432)