Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] add support for abstract handlers#31429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromtimiTao:abstract-handler
Feb 4, 2020

Conversation

timiTao
Copy link
Contributor

@timiTaotimiTao commentedMay 8, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31417
LicenseMIT
Doc PRsymfony/symfony-docs#...

Added handling abstract handler.

@timiTaotimiTao changed the titleadd abstract handler[Messenger] add abstract handlerMay 8, 2019
@nicolas-grekasnicolas-grekas added this to thenext milestoneMay 9, 2019
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd be OK to add this for 4.3 - here are some comments before.

@nicolas-grekasnicolas-grekas modified the milestones:next,4.3May 9, 2019
@nicolas-grekasnicolas-grekas changed the base branch frommaster to4.3May 9, 2019 07:59
@nicolas-grekas
Copy link
Member

Can you pleaserebase -i to get rid of the extra commits?

timiTao reacted with thumbs up emoji

@sroze
Copy link
Contributor

@timiTao can you rebase to get rid of these extra commits in your branch please?

@timiTaotimiTaoforce-pushed theabstract-handler branch 2 times, most recently from800189c to17d5a2dCompareMay 13, 2019 06:45
Copy link
Contributor

@juanmiguelbesadajuanmiguelbesada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In my opinion, I think is better set $container as first parameter of getDefinitionClass method (to keep consistent with other methods)

@fabpotfabpot modified the milestones:4.3,nextMay 27, 2019
@nicolas-grekasnicolas-grekas changed the title[Messenger] add abstract handler[Messenger] fix support for abstract handlersJul 30, 2019
@nicolas-grekasnicolas-grekas changed the title[Messenger] fix support for abstract handlers[Messenger] add support for abstract handlersJul 30, 2019
@nicolas-grekasnicolas-grekas changed the base branch from4.3 to4.4July 30, 2019 19:14
@nicolas-grekasnicolas-grekas changed the base branch from4.4 tomasterFebruary 4, 2020 13:57
@nicolas-grekas
Copy link
Member

Thank you@timiTao.

nicolas-grekas added a commit that referenced this pull requestFeb 4, 2020
This PR was submitted for the 4.4 branch but it was merged into the 5.1-dev branch instead.Discussion----------[Messenger] add support for abstract handlers| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#31417    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Added handling abstract handler.Commits-------22e59f3 [Messenger] fix support for abstract handlers
@nicolas-grekasnicolas-grekas merged commit22e59f3 intosymfony:masterFeb 4, 2020
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@juanmiguelbesadajuanmiguelbesadajuanmiguelbesada left review comments

@srozesrozesroze requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

6 participants
@timiTao@nicolas-grekas@sroze@juanmiguelbesada@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp