NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Intl][4.3] Fix root fallback locale#31416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ro0NL wants to merge0 commits intosymfony:masterfromro0NL:intl-locale-43

Closed

[Intl][4.3] Fix root fallback locale#31416

ro0NL wants to merge0 commits intosymfony:masterfromro0NL:intl-locale-43

Conversation

Copy link

Contributor

ro0NL commentedMay 8, 2019

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT
Doc PR	symfony/symfony-docs#...

Continuation of#31411

carsonbot added Status: Needs Review Intl Bug labels

May 8, 2019

ro0NL commented

May 8, 2019

View reviewed changes

src/Symfony/Component/Intl/Data/Generator/TimezoneDataGenerator.php

		$country =$reader->readEntry($tempDir.'/region',$locale, ['Countries',$zoneToCountry[$id]]);
		}catch (MissingResourceException$e) {
		$country =$this->regionDataProvider->getName($zoneToCountry[$id],'en');
		returnnull;

Copy link

ContributorAuthor

ro0NLMay 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

using the "english" country name as a fallback hardcoded is wrong, it should be determined during runtime fallback resolution. This is causing the removed timezone IDs below, but it's OK.