Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Simplifying SyncTransport and fixing bug with handlers transport#31401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
sroze commentedMay 7, 2019
The approach completely makes sense to me. When you say "it's not quite working", what's the main remaining thing to crack? 🤔 |
1cfccfb to3871592CompareMemberAuthor
weaverryan commentedMay 7, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
d3cd5ca to83c0a0dCompareOskarStark approved these changesMay 8, 2019
Uh oh!
There was an error while loading.Please reload this page.
6479c05 toad655c0Comparead655c0 to8a49eb8CompareMemberAuthor
weaverryan commentedMay 9, 2019
Tests passing - this is ready to go. |
Tobion approved these changesMay 9, 2019
Contributor
Tobion left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So clean 👍
With that I feel we don't need thesend_and_handle logic anymore as the sync transport does the same thing.
So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing
framework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp] send_and_handle: trueis the same as
framework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp, sync]if I'm not mistaken.
MemberAuthor
weaverryan commentedMay 9, 2019
I was thinking the same thing :). That would remove an awkward option. |
Contributor
Tobion commentedMay 9, 2019
I'm looking into creating a PR. |
Contributor
Tobion commentedMay 9, 2019
Thank you@weaverryan. |
Tobion added a commit that referenced this pull requestMay 9, 2019
…h handlers transport (weaverryan)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Simplifying SyncTransport and fixing bug with handlers transport| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | not neededThis is still a WIP, because it's not quite working and tests are a TODO. However, the basic idea is there. This makes SyncTransport less "weird". It acts more like a real transport... except that it "receives" and re-dispatches its message immediately.The bug I'm trying to fix is related to the transport-based handling config that@sroze introduced. It doesn't currently play nice with the sync transport due to the unnatural way that I made it originally.Cheers!Commits-------8a49eb8 Simplifying SyncTransport and fixing bug with handlers transport
fabpot added a commit that referenced this pull requestMay 11, 2019
…ed with SyncTransport (Tobion)This PR was merged into the 4.3 branch.Discussion----------[Messenger] remove send_and_handle which can be achieved with SyncTransport| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#11236The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from#30759So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp] send_and_handle: true```is the same as```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp, sync]```#31401 (review)Commits-------4552b7f [Messenger] remove send_and_handle option which can be achieved with SyncTransport
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestMay 11, 2019
…ed with SyncTransport (Tobion)This PR was merged into the 4.3 branch.Discussion----------[Messenger] remove send_and_handle which can be achieved with SyncTransport| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#11236The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from #30759So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp] send_and_handle: true```is the same as```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp, sync]```symfony/symfony#31401 (review)Commits-------4552b7f5b2 [Messenger] remove send_and_handle option which can be achieved with SyncTransport
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestMay 11, 2019
…ed with SyncTransport (Tobion)This PR was merged into the 4.3 branch.Discussion----------[Messenger] remove send_and_handle which can be achieved with SyncTransport| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#11236The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from #30759So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp] send_and_handle: true```is the same as```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp, sync]```symfony/symfony#31401 (review)Commits-------4552b7f5b2 [Messenger] remove send_and_handle option which can be achieved with SyncTransport
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestJan 28, 2020
…ed with SyncTransport (Tobion)This PR was merged into the 4.3 branch.Discussion----------[Messenger] remove send_and_handle which can be achieved with SyncTransport| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | no| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#11236The send_and_handle option is pretty awkward and we don't need it anymore because the same thing can be achieved with the SyncTransport from #30759So the following example from the doc inhttps://symfony.com/doc/current/messenger.html#routing```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp] send_and_handle: true```is the same as```yamlframework: messenger: routing: 'My\Message\ThatIsGoingToBeSentAndHandledLocally': senders: [amqp, sync]```symfony/symfony#31401 (review)Commits-------4552b7f5b2 [Messenger] remove send_and_handle option which can be achieved with SyncTransport
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a WIP, because it's not quite working and tests are a TODO. However, the basic idea is there. This makes SyncTransport less "weird". It acts more like a real transport... except that it "receives" and re-dispatches its message immediately.
The bug I'm trying to fix is related to the transport-based handling config that@sroze introduced. It doesn't currently play nice with the sync transport due to the unnatural way that I made it originally.
Cheers!