Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto#31382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@l-vo
Copy link
Contributor

@l-vol-vo commentedMay 4, 2019•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

During the refactoring for#29211 , it seems a little bug was introduced. When using runInSeparateProcess, deprecation message isn't unserialized anymore.

…er refactoring(when using runInSeparateProcess)
Copy link
Contributor

@greg0iregreg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Woops! My bad… your fix seems good 👍

@l-vo
Copy link
ContributorAuthor

l-vo commentedMay 5, 2019

@greg0ire It may occur on big refactos... Thank you for your feedback 🙂

greg0ire reacted with heart emoji

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneMay 5, 2019
@nicolas-grekas
Copy link
Member

Thank you@l-vo.

@nicolas-grekasnicolas-grekas merged commitf522729 intosymfony:masterMay 5, 2019
nicolas-grekas added a commit that referenced this pull requestMay 5, 2019
…nErrorHandler refacto (l-vo)This PR was merged into the 4.3-dev branch.Discussion----------[PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |During the refactoring for#29211 , it seems a little bug was introduced. When using runInSeparateProcess, deprecation message isn't unserialized anymore.Commits-------f522729 [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refactoring
@l-vol-vo deleted the fix_not_unserialized_logs_after_deprecation_handler_refacto branchMay 8, 2019 17:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@greg0iregreg0iregreg0ire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@l-vo@nicolas-grekas@greg0ire@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp