I propose to add a new attribute toBaseType class so it is easy to include html tags in labels for, both, buttons and other elements that inherit fromFormType class. This gives you an ability to add, e.g. a glyphicon to a button, or a link to a checkbox, simply inside theFormBuilder, which means you can just do

{{ form(form) }}

inside a template.

Sidenotes

I have started working on this two days ago and it the meantime@alexander-schranz made a similar proposition in[Form] Add label_raw attribute to form theme #31358. If necessary, I can close my PR and@alexander-schranz can include my suggestions inside his PR.
I have just read in[Form][TwigBridge] Add help_html #29861 that@mpiot wanted to include this idea in his PR. With respect to@xabbuh's comments from that PR, I hope that my PR will be at least a good place to discuss, if the proposed feature is a good solution.

carsonbot added Status: Needs Review Form Feature labels

May 3, 2019

xabbuh mentioned this pull request

May 4, 2019

[Form] Add label_raw attribute to form theme#31358

Closed

xabbuh added this to thenext milestone

May 4, 2019

Copy link

Contributor

alexander-schranz commentedMay 9, 2019•
edited
Loading

As described in#31358 I think it totally make sense to have label_html attribute in it as we also have help_html attribute. 👍 for this.

wouterj mentioned this pull request

May 12, 2019

Add documentation for label_raw attributesymfony/symfony-docs#11513

Closed

Copy link

Contributor

alexander-schranz commentedMay 13, 2019

@przemyslaw-bogusz the label is also used inside the button example and could contain html there also see:https://github.com/symfony/symfony/pull/31358/files

Copy link

Contributor

AndreasA commentedMay 28, 2019•
edited
Loading

Hi, just wondering will this make it into Symfony 4.3?

Copy link

ContributorAuthor

przemyslaw-bogusz commentedMay 28, 2019

@AndreasA I've been busy preparing for SymfonyLive in Warsaw, but that's on the list of my priorities, so I will fix the tests and complete it as soon as I can. However, it doesn't mean it will be automatically approved. If you like the idea, give it a 'thumbs up' or leave a positive comment.

Copy link

Contributor

AndreasA commentedMay 28, 2019•
edited
Loading

I think this would be really helpful. Especially in combination with thelabel_translation_parameters it would allow to create terms and condition checkboxes with links in them way easier than it is now.

przemyslaw-bogusz force-pushed thelabel_html branch fromd92e2a8 to05a1c39Compare

May 29, 2019 15:13

Copy link

Contributor

alexander-schranz commentedJun 12, 2019

@przemyslaw-bogusz the tests seems to fail because $label_html is not define in the form_label.html.php not sure how this happens maybe you can try to debug the tests and try to fix it?

przemyslaw-bogusz force-pushed thelabel_html branch from05a1c39 to5a50ee8Compare

June 16, 2019 19:20

Copy link

ContributorAuthor

przemyslaw-bogusz commentedJun 17, 2019

I've tried a different approach by implementing this feature inFormType instead ofBaseType, but in either case tests keep failing with the same result - variable "label_html" does not exist. Nevertheless, it works in real application with different combinations of field types and themes. Maybe@xabbuh or@chr-hertel could shed some light?

przemyslaw-bogusz changed the base branch frommaster to4.4

June 24, 2019 07:15

przemyslaw-bogusz changed the base branch from4.4 tomaster

June 25, 2019 22:35

przemyslaw-bogusz force-pushed thelabel_html branch froma23d9eb tofc0ee8fCompare

June 25, 2019 23:11

przemyslaw-bogusz requested a review fromxabbuh as acode owner

June 25, 2019 23:11

przemyslaw-bogusz force-pushed thelabel_html branch fromfc0ee8f to46f625fCompare

June 25, 2019 23:24

przemyslaw-bogusz force-pushed thelabel_html branch from2617c46 tob4c0924Compare

February 9, 2020 14:37

przemyslaw-bogusz mentioned this pull request

Feb 9, 2020

Form Labels translation does not allow raw content (Add label_html option)#35598

Closed

Copy link

ContributorAuthor

przemyslaw-bogusz commentedFeb 10, 2020

@xabbuh I have started working on this some time ago, but I had problem with a single space, that which caused the tests to fail. I have fixed this, but there is still some issue with Travis on PHP 7.4. I could really use some help to solve this out, because there are a few people, who like this proposition -#35598.

Copy link

Member

xabbuh commentedFeb 14, 2020

@przemyslaw-bogusz I think making sure that the Twig bridge always gets the Form component in version 5.1 or higher should solve it. We would need to make some changes to the Twid bridge'scomposer.json file.

require-dev:

"symfony/form": "^5.1"

conflict:

"symfony/form": "<5.1"

Copy link

ContributorAuthor

przemyslaw-bogusz commentedFeb 14, 2020

@xabbuh Thanks a lot. That solved the issue. However, now there is a single test in Cache Component failing.

Copy link

Member

fabpot commentedFeb 15, 2020

It looks like this PR contains not related commits. Can you rebase and force push?

nicolas-grekas force-pushed thelabel_html branch from3fb25c0 to7037723Compare

February 15, 2020 10:46

nicolas-grekas approved these changes

Feb 15, 2020

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I rebased + squashed)

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 15, 2020

HeahDude approved these changes

Feb 15, 2020

View reviewed changes

Copy link

Contributor

HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! We also need a note in the form component CHANGELOG.

Copy link

ContributorAuthor

przemyslaw-bogusz commentedFeb 15, 2020

I have updated the form component changelog. Sorry for the mess with the commits and thanks for the cleanup.

nicolas-grekas reviewed

Feb 15, 2020

View reviewed changes

src/Symfony/Component/Form/CHANGELOG.md OutdatedShow resolvedHide resolved

przemyslaw-bogusz changed the title~~[Form] Add label_html attribute~~[Form] Add label_html attribute test

Feb 18, 2020

przemyslaw-bogusz changed the title~~[Form] Add label_html attribute test~~[Form] Add label_html attribute

Feb 18, 2020

przemyslaw-bogusz force-pushed thelabel_html branch from5a25ef1 toab9f795Compare

February 18, 2020 23:14

przemyslaw-bogusz force-pushed thelabel_html branch fromab9f795 to02d9f0bCompare

February 27, 2020 22:08

Copy link

ContributorAuthor

przemyslaw-bogusz commentedFeb 28, 2020

I removed the CHANGELOG update, and without AppVeyor CI is green again.

javiereguiluz approved these changes

Mar 3, 2020

View reviewed changes

Copy link

Member

javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice and useful feature!

przemyslaw-bogusz mentioned this pull request

Mar 8, 2020

[Form] Add description of label_html optionsymfony/symfony-docs#13316

Merged

[Form] Add label_html attribute

239fe04

nicolas-grekas force-pushed thelabel_html branch from02d9f0b to239fe04Compare

March 12, 2020 17:18

Copy link

Member

nicolas-grekas commentedMar 12, 2020

Thank you@przemyslaw-bogusz.

nicolas-grekas merged commit49e5d57 intosymfony:master

Mar 12, 2020

Copy link

Contributor

alexander-schranz commentedMar 12, 2020

@przemyslaw-bogusz good work nice to see this merged!

Copy link

ContributorAuthor

przemyslaw-bogusz commentedMar 13, 2020

@alexander-schranz Thanks! I wish you all the best in future PRs.

przemyslaw-bogusz deleted the label_html branch

March 13, 2020 09:04

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request

Mar 14, 2020

minor#13316[Form] Add description of label_html option (przemyslaw-…

e0d1516

…bogusz)This PR was squashed before being merged into the master branch (closes#13316).Discussion----------[Form] Add description of label_html option| Q             | A| ------------- | ---| Feature PR      |symfony/symfony#31375| PR author(s)      |@przemyslaw-bogusz| Merged in  | WCMCommits-------7a74bb3 [Form] Add description of label_html option

przemyslaw-bogusz mentioned this pull request

Mar 23, 2020

[Validator] Add description for AtLeastOne constraintsymfony/symfony-docs#13409

Merged

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request

Mar 24, 2020

minor#13409[Validator] Add description for AtLeastOne constraint (p…

e2a8552

…rzemyslaw-bogusz)This PR was squashed before being merged into the master branch (closes#13409).Discussion----------[Validator] Add description for AtLeastOne constraint| Q             | A| ------------- | ---| Feature PR      |symfony/symfony#31375| PR author(s)      |@przemyslaw-bogusz| Merged in  | 5.1-dev| Fixes |#13355Commits-------5ba5224 [Validator] Add description for AtLeastOne constraint