NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] properly parse dates before the Gregorian calendar#31374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

xabbuh wants to merge1 commit intosymfony:3.4fromxabbuh:issue-29610-31057

Closed

[Form] properly parse dates before the Gregorian calendar#31374

xabbuh wants to merge1 commit intosymfony:3.4fromxabbuh:issue-29610-31057

Conversation

Copy link

Member

xabbuh commentedMay 3, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#29610 #31057
License	MIT
Doc PR

xabbuh added this to the3.4 milestone

May 3, 2019

carsonbot added Status: Needs Review Form Bug labels

May 3, 2019

ro0NL reviewed

May 3, 2019

View reviewed changes

...mfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php OutdatedShow resolvedHide resolved

xabbuh force-pushed theissue-29610-31057 branch from2a87abe toda8ba92Compare

May 3, 2019 14:12

xabbuh marked this pull request as ready for review

May 3, 2019 14:14

This was referencedMay 3, 2019

[Form] reject DateType values before begin of gregorian calendar?#29610

Open

[Form] BirthdayType and dates before 1583#31057

Open

nicolas-grekas reviewed

May 5, 2019

View reviewed changes

...mfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php OutdatedShow resolvedHide resolved

xabbuh force-pushed theissue-29610-31057 branch fromda8ba92 to1c8c387Compare

May 6, 2019 19:01

nicolas-grekas previously approved these changes

May 9, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

May 9, 2019

nicolas-grekas dismissed theirstale review

May 9, 2019 08:35

tests are failing!

xabbuh force-pushed theissue-29610-31057 branch from1c8c387 tocfcc9a7Compare

May 9, 2019 09:08

Copy link

Member

nicolas-grekas commentedMay 11, 2019

Status: needs work
(tests fail on appveyor)

carsonbot added Status: Needs Work and removed Status: Reviewed labels

May 11, 2019

Copy link

Member

javiereguiluz commentedJul 17, 2019

Could any Windows user please help us debug the failing test? Thanks.

Copy link

Member

nicolas-grekas commentedJul 18, 2019

Could the failure be related to an old version of intl?

Copy link

Contributor

ro0NL commentedJul 18, 2019•
edited
Loading

i wasnt able to reproduce with ICU 52.1 on Linux

php -r "var_dump((new DateTime((new IntlDateFormatter('en', 2, -1, new DateTimeZone('UTC'), 1, 'yyyy-MM-dd HH:mm:ss'))->format(-32157216000)))->format('Y-m-d'));"string(10) "0950-12-19"

xabbuh mentioned this pull request

Jul 23, 2019

[Intl] relax some date parser patterns#32679

Merged

properly parse dates before the Gregorian calendar

d5c896f

xabbuh force-pushed theissue-29610-31057 branch fromcfcc9a7 tod5c896fCompare

July 23, 2019 13:29

nicolas-grekas added a commit that referenced this pull request

Jul 23, 2019

bug#32679[Intl] relax some date parser patterns (xabbuh)

a2da86a

This PR was merged into the 3.4 branch.Discussion----------[Intl] relax some date parser patterns| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |While debugging the failures in#31374 I realised that the `IntlDateFormatter` from the Intl component parses dates more strictly than PHP's `IntlDateFormatter` class does.Commits-------7d0793a relax some date parser patterns