Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Made countries ISO 3166 compliant + exclude Zzzz script code#31365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ro0NL commentedMay 2, 2019
| self::EUROZONE_ID =>true, | ||
| self::UNITED_NATIONS_ID =>true, | ||
| // No longer exists | ||
| self::NETHERLANDS_ANTILLES_ID =>true, |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
removed upstream 👍
This was referencedMay 2, 2019
Merged
ContributorAuthor
ro0NL commentedMay 6, 2019
it seems there are a few more codes that should be excluded before we comply with ISO-3166 |
fabpot added a commit that referenced this pull requestMay 7, 2019
This PR was merged into the 3.4 branch.Discussion----------[Intl] Cleanup| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->cleanup of#31365 for 3.4 + some other stuff to keep in sync across branchesCommits-------70a941e [Intl] Cleanup
Member
fabpot commentedMay 7, 2019
@ro0NL Can you rebase this one please? |
ContributorAuthor
ro0NL commentedMay 7, 2019
@fabpot done. |
fabpot approved these changesMay 7, 2019
Member
fabpot commentedMay 7, 2019
Thank you@ro0NL. |
fabpot added a commit that referenced this pull requestMay 7, 2019
…z script code (ro0NL)This PR was merged into the 4.3-dev branch.Discussion----------[Intl] Made countries ISO 3166 compliant + exclude Zzzz script code| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes (including intl-data group)| Fixed tickets |#31350 (comment),#18613| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->For consistency :)Commits-------1bb7dde [Intl] Made countries ISO 3166 compliant + exclude Zzzz script code
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
For consistency :)