Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit#31364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromJustBlackBird:issue-27035
May 6, 2019

Conversation

@JustBlackBird
Copy link
Contributor

@JustBlackBirdJustBlackBird commentedMay 2, 2019•
edited
Loading

The change allowsimple-phpunit to be included without#!/usr/bin/env php string outputted.

Also it's the first step tofix#27035 (the second one is to change phpunit bridge recipe).

The reason why I fix a closed issue is because PHPStorm don't want to parse output from simple-phpunit with extra shebang.

phpstorm-phpunit

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27035
LicenseMIT

@JustBlackBird
Copy link
ContributorAuthor

Not sure if I should fix code style... The code is still the same but moved to another file.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, no need to care about the CS I agree.
This should be submitted on master - it's not a real bug fix. We can merge it for 4.3 IMHO.
Pleas also open a PR for the recipe so we can discuss it at the same time.

@JustBlackBird
Copy link
ContributorAuthor

JustBlackBird commentedMay 5, 2019•
edited
Loading

@nicolas-grekas I've changed target to master branch and open a PR for flex recipes repo:symfony/recipes#584

…unitThe change allow `simple-phpunit` to be included without`#!/usr/bin/env php` string outputted.Also it's the first step tofixsymfony#27035 (the second one is to changephpunit bridge recipe).
JustBlackBird added a commit to JustBlackBird/recipes that referenced this pull requestMay 5, 2019
nicolas-grekas pushed a commit to JustBlackBird/recipes that referenced this pull requestMay 5, 2019
@fabpot
Copy link
Member

Thank you@JustBlackBird.

@fabpotfabpot merged commit74a0be3 intosymfony:masterMay 6, 2019
fabpot added a commit that referenced this pull requestMay 6, 2019
… bin/simple-phpunit (JustBlackBird)This PR was merged into the 4.3-dev branch.Discussion----------[Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunitThe change allow `simple-phpunit` to be included without `#!/usr/bin/env php` string outputted.Also it's the first step tofix#27035 (the second one is to change phpunit bridge recipe).The reason why I fix a closed issue is because PHPStorm don't want to parse output from simple-phpunit with extra shebang.![phpstorm-phpunit](https://user-images.githubusercontent.com/1167086/57097433-6c9b2a00-6d20-11e9-9979-0c2c6d24147d.png)| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27035| License       | MITCommits-------74a0be3 [Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit
@JustBlackBird
Copy link
ContributorAuthor

You're welcome@fabpot !

@fabpotfabpot mentioned this pull requestMay 9, 2019
nicolas-grekas added a commit that referenced this pull requestJun 22, 2021
…hen using simple-phpunit (Taluu)This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] fix handling the COMPOSER_BINARY env var when using simple-phpunit| Q             | A| ------------- | ---| Branch?       | 4.4 and next| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#41774| License       | MITSince the renaming of the simple phpunit file (from the shebang to the php file) in#31364, it looks like the change made from#36566 was lost as it seems to have been merged after.So this PR is an attempt to "restore" that functionnality, as it was considered a bug fix on 3.4 at the time.poke `@nicolas`-grekasCommits-------9589b52 Reapply the change to allow to set the composer binary path
markovlatkovic pushed a commit to markovlatkovic/recipes that referenced this pull requestMay 24, 2024
markovlatkovic pushed a commit to markovlatkovic/recipes that referenced this pull requestMay 24, 2024
mo-melvin77 added a commit to mo-melvin77/recipes that referenced this pull requestJun 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

[PhpUnitBridge] Shebang is printed in the output while using bin/phpunit

5 participants

@JustBlackBird@fabpot@nicolas-grekas@lyrixx@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp