Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] Backport #28070#31341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge1 commit intosymfony:3.4fromro0NL:intl-backport
Closed

[Intl] Backport #28070#31341

ro0NL wants to merge1 commit intosymfony:3.4fromro0NL:intl-backport

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedMay 1, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

This is a backport of#28070 for the Intl component, to ensure consistent data generation as much as possible across branches. I bumped into it after refactoring in#31337 (comment), which also targets 3.4

this should avoid some merge conflicts / inconsistencies.

@ro0NL
Copy link
ContributorAuthor

Alternatively i can do a new PR for 4.2, after#31337, as the generated data is not really used by the translator component in 3.4 😕

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMay 1, 2019•
edited
Loading

I also remember i discussed with@nicolas-grekas to backport#28833 as well, AFAIK then we'll generate 100% the same data between 3.4 and 4.2 (we should check)

If so, we dont need to re-generate data per branch. One less trap, but one more BC break for the data ...

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Dealing with this in the same days as translations.

@ro0NL
Copy link
ContributorAuthor

If so, we dont need to re-generate data per branch

actually this is a required step anyway, as we added timezones in master. So for each ICU update we need to remember it :)

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMay 1, 2019•
edited
Loading

Discussed with@fabpot to close here and forget about it. Let's avoid the backporting/BC break hassle.

Given the re-generation is required per branch/ICU update (sorry :P) we should rely on the process instead.

@ro0NLro0NL closed thisMay 1, 2019
@ro0NLro0NL deleted the intl-backport branchMay 1, 2019 12:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ro0NL@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp