NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"#31338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromnicolas-grekas:ses-revert

May 1, 2019

Merged

Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"#31338

fabpot merged 1 commit intosymfony:3.4fromnicolas-grekas:ses-revert

May 1, 2019

Conversation

Copy link

Member

nicolas-grekas commentedMay 1, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

This reverts commit029fb2e, reversing
changes made to9dad29d.

Reverts#30620
Replaces#31215

We don't need to solve this in 3.4
Making the session resettable should be done on master, by implementingResetInterface.
On 3.4 apps, one should write a dedicatedSessionResetter that would implement the reverted logic.

Revert "bugsymfony#30620[FrameworkBundle][HttpFoundation] make sess…

4177331

…ion service resettable (dmaicher)"This reverts commit029fb2e, reversingchanges made to9dad29d.

nicolas-grekas added this to the3.4 milestone

May 1, 2019

carsonbot added Status: Needs Review FrameworkBundle HttpFoundation Bug Status: Reviewed and removed Status: Needs Review labels

May 1, 2019

fabpot approved these changes

May 1, 2019

View reviewed changes

Copy link

Member

fabpot commentedMay 1, 2019

Thank you@nicolas-grekas.

fabpot merged commit4177331 intosymfony:3.4

May 1, 2019

fabpot added a commit that referenced this pull request

May 1, 2019

bug#31338Revert "bug#30620[FrameworkBundle][HttpFoundation] make …

9041637

…session service resettable (dmaicher)" (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------Revert "bug#30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -This reverts commit029fb2e, reversingchanges made to9dad29d.Reverts#30620Replaces#31215We don't need to solve this in 3.4Making the session resettable should be done on master, by implementing `ResetInterface`.On 3.4 apps, one should write a dedicated `SessionResetter` that would implement the reverted logic.Commits-------4177331 Revert "bug#30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"