Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Extra timezone tests#31325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedApr 30, 2019
Thank you@ro0NL. |
This PR was merged into the 4.3-dev branch.Discussion----------[Intl] Extra timezone tests| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes (including intl-data group)| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Guarantees timezone data integrity. Ideally to go before#31292 :)Commits-------a3cac2b [Intl] Extra timezone tests
| { | ||
| try { | ||
| $this->assertInternalType('string', Timezones::getCountryCode($timezone)); | ||
| }catch (MissingResourceException$e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if it is possible for valid timezone ids to throw a MissingResourceException when trying to get their code, we need to document that in the interface, as it becomes necessary to catch it when using it (or maybe the Timezones class should handle that internally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see#31332
| */ | ||
| publicfunctiontestGetGmtOffsetAvailability(string$timezone) | ||
| { | ||
| $this->assertInternalType('int', Timezones::getRawOffset($timezone)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't we ensure that with return types instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it does :D im on it.
This PR was squashed before being merged into the 4.3-dev branch (closes#31332).Discussion----------[Intl] Add phpdoc| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#31325 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Commits-------22a6f7b [Intl] Add phpdoc
Guarantees timezone data integrity. Ideally to go before#31292 :)