Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] deprecates tag !tagged in favor of !tagged_iterator#31321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromjschaedl:di-tagged_iterator
Jun 9, 2019

Conversation

@jschaedl
Copy link
Contributor

@jschaedljschaedl commentedApr 29, 2019•
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#31289
LicenseMIT
Doc PRtbd.

Todo

  • fix tests

@jschaedljschaedl changed the title[DI] deprecates tag tagged in favor of tagged_iterator[DI] deprecates tag !tagged in favor of !tagged_iteratorApr 29, 2019
@jschaedljschaedlforce-pushed thedi-tagged_iterator branch 3 times, most recently from44c3096 to6ebb340CompareMay 1, 2019 18:52
@jschaedl
Copy link
ContributorAuthor

The TravisCi failure seems strange to me. I added the new argument typetagged_iterator to theservices-1.0.xsd (See:https://github.com/symfony/symfony/pull/31321/files#diff-0e535437d820c04db5c34dcc4210e3da) and the XmlParsingException shouldn't occur. Maybe a caching issue?

<!-- transports-->
<serviceid="messenger.transport_factory"class="Symfony\Component\Messenger\Transport\TransportFactory">
<argumenttype="tagged"tag="messenger.transport_factory" />
<argumenttype="tagged_iterator"tag="messenger.transport_factory" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this means FWB now needs DI v4.4
this is why tests fail: the composer.json needs an update

@nicolas-grekas
Copy link
Member

(rebase needed also)

@jschaedljschaedl changed the base branch frommaster to4.4June 1, 2019 08:55
@nicolas-grekas
Copy link
Member

The failing job is checking out branch 4.4 and loading dependencies with your patch applied.
This highlights that FrameworkBundle 4.4 is currently not compatible with DI 5.0 in your PR.
That's what needs to be fixed.

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe we should keep tests for the legacy behaviour though to make sure that we do not accidentally break it

@nicolas-grekas
Copy link
Member

Thank you@jschaedl.

jschaedl reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commitab8fb18 intosymfony:4.4Jun 9, 2019
nicolas-grekas added a commit that referenced this pull requestJun 9, 2019
…or (jschaedl)This PR was squashed before being merged into the 4.4 branch (closes#31321).Discussion----------[DI] deprecates tag !tagged in favor of !tagged_iterator| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#31289| License       | MIT| Doc PR        | tbd.### Todo- [x] fix testsCommits-------ab8fb18 [DI] deprecates tag !tagged in favor of !tagged_iterator
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJun 9, 2019•
edited
Loading

@jschaedl would you mind sending a PR to remove the deprecated codes on master?

@jschaedl
Copy link
ContributorAuthor

@nicolas-grekas Sure, I'm happy to do that :-)

nicolas-grekas added a commit that referenced this pull requestJun 9, 2019
…terator (jschaedl)This PR was merged into the 5.0-dev branch.Discussion----------[DI] remove deprecated tag !tagged in favor of !tagged_iterator| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | yes     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | related ticket#31289   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#tbd <!-- required for new features -->This PR removes tag `tagged` which was deprecated in#31321Commits-------9978184 [DI] removed tagged
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJun 11, 2019
This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes#11708).Discussion----------[DI] Add deprecation info for !taggedFixes#11706Feature PR:symfony/symfony#31321Commits-------65263e1 [DI] Add deprecation info for !tagged
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
@jschaedljschaedl deleted the di-tagged_iterator branchFebruary 23, 2020 08:01
Zales0123 added a commit to Sylius/Sylius that referenced this pull requestJul 25, 2022
This PR was merged into the 1.12 branch.Discussion----------| Q               | A                                                            ||-----------------|--------------------------------------------------------------|| Branch?         | 1.12 <!-- see the comment below -->          || Bug fix?        | no                                                       || New feature?    | no                                                       || BC breaks?      | no                                                       || Deprecations?   | no|| Related tickets | || License         | MIT                                                          |As `tagged` has been deprecated in Symfony 4.4:symfony/symfony#31321<!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation:https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html-->Commits-------8e9eb8c Rename tag tagged to tagged_iterator
Zales0123 added a commit to Sylius/SyliusApiBundle that referenced this pull requestJul 25, 2022
This PR was merged into the 1.12 branch.Discussion----------| Q               | A                                                            ||-----------------|--------------------------------------------------------------|| Branch?         | 1.12 <!-- see the comment below -->          || Bug fix?        | no                                                       || New feature?    | no                                                       || BC breaks?      | no                                                       || Deprecations?   | no|| Related tickets | || License         | MIT                                                          |As `tagged` has been deprecated in Symfony 4.4:symfony/symfony#31321<!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation:https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html-->Commits-------8e9eb8cffeed5d19e4cdb60409faca4d4b4fd5cd Rename tag tagged to tagged_iterator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@jschaedl@nicolas-grekas@OskarStark@ro0NL@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp