Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Add intl/choice_translation_locale option to TimezoneType#31294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromro0NL:tz-intl
May 13, 2019
Merged

[Form] Add intl/choice_translation_locale option to TimezoneType#31294

fabpot merged 1 commit intosymfony:4.3fromro0NL:tz-intl
May 13, 2019

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedApr 27, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28836
LicenseMIT
Doc PRsymfony/symfony-docs#11503

final step :)

for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see#31293 +#31295

having a special built ingroup_by' => 'gmt_offset' util would be nice, and can be done in the future.

includes#31434

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The Form part LGTM.

nicolas-grekas added a commit that referenced this pull requestMay 9, 2019
This PR was merged into the 4.3 branch.Discussion---------- [Intl] Revise timezone name generation| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes (inlcluding intl-data group)| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This is the final polishing needed for#31294 :)I've realized it's much easier to de-duplicate by processing fallback locales separate, and then only keep the diff compared to a specific locale. More or less the same approach `LocaleDataGenerator` already follows. I was trying to be clever and filter based on inheritance in a single process; bad idea.Includesro0NL@31591d0 (ref#31432)Commits-------bfdb4ed [Intl] Revise timezone name generation
@nicolas-grekas
Copy link
Member

Time for rebase.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMay 9, 2019•
edited
Loading

4.3? would makes sense as we added all the timezone related infra in 4.3 already, which purpose it was to support this feature 😅

@ro0NLro0NL changed the base branch frommaster to4.3May 9, 2019 14:11
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3May 9, 2019
nicolas-grekas
nicolas-grekas previously approved these changesMay 9, 2019
@ro0NL
Copy link
ContributorAuthor

Figured it out, locally i invokedTimezoneTypeTest direct. It passed :)

testing the whole suite, shows we have a global state issue with the default locale. Last commit should do, not sure why it starts failing now, as other intl types have the same test :/

fabpot added a commit that referenced this pull requestMay 10, 2019
This PR was merged into the 3.4 branch.Discussion----------[Form] Restore default locale during tests| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes-ish| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#31294 (comment)| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This fixes the failing tests in#31294Commits-------7fce86f [Form] Restore default locale during tests
@ro0NL
Copy link
ContributorAuthor

All good (failures unrelated)

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commit001b930 intosymfony:4.3May 13, 2019
fabpot added a commit that referenced this pull requestMay 13, 2019
…mezoneType (ro0NL)This PR was merged into the 4.3 branch.Discussion----------[Form] Add intl/choice_translation_locale option to TimezoneType| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28836| License       | MIT| Doc PR        |symfony/symfony-docs#11503final step :)for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see#31293 +#31295having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future.includes#31434Commits-------001b930 [Form] Add intl/choice_translation_locale option to TimezoneType
@ro0NLro0NL deleted the tz-intl branchMay 13, 2019 06:57
@fabpotfabpot mentioned this pull requestMay 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoyceruto approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@ro0NL@nicolas-grekas@fabpot@stof@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp