Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Remove default option grouping in TimezoneType#31293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot approved these changesApr 28, 2019
ContributorAuthor
ro0NL commentedApr 29, 2019
(failures unrelated; deps=high should pass once merged upstream) |
Member
fabpot commentedApr 29, 2019
Thank you@ro0NL. |
fabpot added a commit that referenced this pull requestApr 29, 2019
…(ro0NL)This PR was squashed before being merged into the 4.3-dev branch (closes#31293).Discussion----------[Form] Remove default option grouping in TimezoneType| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->This removes some complexity from the TimezoneType. The default option grouping is really a simple `group_by` (+ `choice_label`) configuration for the end-user, i.e.:```php'group_by' => function($choice) { if (false !== $i = strpos($choice, '/')) { return substr($choice, 0, $i); } return 'Other';},```The grouping labels are not really i18n friendly, so i think SF should opt-out by default.Commits-------ebe6179 [Form] Remove default option grouping in TimezoneType
Merged
fabpot added a commit that referenced this pull requestMay 13, 2019
…mezoneType (ro0NL)This PR was merged into the 4.3 branch.Discussion----------[Form] Add intl/choice_translation_locale option to TimezoneType| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#28836| License | MIT| Doc PR |symfony/symfony-docs#11503final step :)for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see#31293 +#31295having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future.includes#31434Commits-------001b930 [Form] Add intl/choice_translation_locale option to TimezoneType
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some complexity from the TimezoneType. The default option grouping is really a simple
group_by(+choice_label) configuration for the end-user, i.e.:The grouping labels are not really i18n friendly, so i think SF should opt-out by default.