Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] RoutableMessageBus route to default bus#31288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a3e17df to8fde9b3Comparesroze suggested changesApr 28, 2019
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
505cc53 toc15ba90Comparesroze approved these changesApr 28, 2019
Contributor
sroze left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Two comments.
| if (!$this->busLocator->has($busNameStamp->getBusName())) { | ||
| thrownewInvalidArgumentException(sprintf('Invalid busname "%s"on BusNameStamp.',$busNameStamp->getBusName())); | ||
| if (!$this->busLocator->has($busName)) { | ||
| thrownewInvalidArgumentException(sprintf('Busname "%s"does not exists.',$busName)); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| thrownewInvalidArgumentException(sprintf('Busname "%s" does notexists.',$busName)); | |
| thrownewInvalidArgumentException(sprintf('Busnamed "%s" does notexist.',$busName)); |
| { | ||
| $this->expectException(InvalidArgumentException::class); | ||
| $this->expectExceptionMessage('does not contain a BusNameStamp'); | ||
| $this->expectExceptionMessage(sprintf('Bus name "%s" does not exists.', MessageBusInterface::class)); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you move these to annotations instead actually? It's more readable.
6ed20d8 to8513c4fCompare8513c4f toc4e5e83CompareMember
fabpot commentedMay 1, 2019
Thank you@dirk39. |
fabpot added a commit that referenced this pull requestMay 1, 2019
…irk39)This PR was squashed before being merged into the 4.3-dev branch (closes#31288).Discussion----------[Messenger] RoutableMessageBus route to default bus| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31200| License | MIT| Doc PR | Not neededHi! I modified the behaviour of RoutableMessageBus to route message without BusNameStamp to default bus instead of raise an exception.Made with ❤️ by [](https://www.meetup.com/it-IT/Open-Source-Saturday-Milano/)Commits-------c4e5e83 [Messenger] RoutableMessageBus route to default bus
%5d(https%3a%2f%2fwww.meetup.com%2fit-IT%2fOpen-Source-Saturday-Milano%2f){kind=link}
Member
fabpot commentedMay 1, 2019
Comments addressed in2eda6ff |
25 tasks
Merged
Tobion added a commit that referenced this pull requestMay 11, 2019
This PR was merged into the 4.3 branch.Discussion----------[Messenger] Fix routable message bus default bus| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | not neededIn#31288, we gave the `RoutableMessageBus` a "default" bus. We did that by using the `MessageBusInterface` service in the locator. But, no such service exists - I think that was just a huge oversight (and maybe@dirk39 named a bus this in the project he was testing on?). The services in the locator are very simply the keys under `framework.messenger.buses` or the default, which is a single `messenger.bus.default` id. There is an alias in the container for `MessageBusInterface`, but this is not added to the locator (and adding it would be a bit awkward, as `MessengerPass` is in the component and the interface alias is entirely a framework thing).Cheers!Commits-------42e0536 Changing how RoutableMessageBus fallback bus works
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I modified the behaviour of RoutableMessageBus to route message without BusNameStamp to default bus instead of raise an exception.
Made with ❤️ by