Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebServerBundle] Change the default pidfile location to cache directory#31280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@jschaedl
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29160
LicenseMIT
Doc PRtbd.

@jschaedljschaedlforce-pushed theweb-server-bundle_store-pidfile-project-dir branch fromae09416 toee32c98CompareApril 26, 2019 20:36
@jschaedljschaedl marked this pull request as ready for reviewApril 26, 2019 20:43
@jschaedljschaedl changed the titleChanges default pidfile location to project dir #29160[WebServerBundle] Changes default pidfile location to project dir #29160Apr 26, 2019
@jschaedljschaedl changed the title[WebServerBundle] Changes default pidfile location to project dir #29160[WebServerBundle] Changes default pidfile location to project dirApr 26, 2019
@jschaedljschaedl changed the title[WebServerBundle] Changes default pidfile location to project dir[WebServerBundle] Change the default pidfile location to projectDirApr 26, 2019
@chalasrchalasr added this to thenext milestoneApr 26, 2019
@jschaedljschaedlforce-pushed theweb-server-bundle_store-pidfile-project-dir branch fromee32c98 to3aae37dCompareApril 27, 2019 06:01
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedApr 27, 2019•
edited
Loading

I'm still on the side this should be somewhere in thevar directory.

@jschaedljschaedlforce-pushed theweb-server-bundle_store-pidfile-project-dir branch from74bc733 to2be7b89CompareApril 27, 2019 11:45
nicolas-grekas
nicolas-grekas previously approved these changesApr 27, 2019
@nicolas-grekasnicolas-grekas dismissed theirstale reviewApril 27, 2019 13:29

tests are failing

@jschaedljschaedl changed the title[WebServerBundle] Change the default pidfile location to projectDir[WebServerBundle] Change the default pidfile location to cache directoryApr 28, 2019
@jschaedl
Copy link
ContributorAuthor

@nicolas-grekas

tests are failing

Tests are fixed but the AppVeyor build is still failing... 😕

@nicolas-grekas
Copy link
Member

By the way, not sure it's a good idea to use the parent directory of the cache directory. It may not be writable.

same issue withgetcwd(), yet this is for dev, I'd guess it's because this is never an issue with dev?

@fabpotfabpotforce-pushed theweb-server-bundle_store-pidfile-project-dir branch from0022b33 to2e14b6eCompareApril 29, 2019 09:33
@fabpot
Copy link
Member

Thank you@jschaedl.

jschaedl reacted with hooray emoji

@fabpotfabpot merged commit2e14b6e intosymfony:masterApr 29, 2019
fabpot added a commit that referenced this pull requestApr 29, 2019
…to cache directory (jschaedl)This PR was squashed before being merged into the 4.3-dev branch (closes#31280).Discussion----------[WebServerBundle] Change the default pidfile location to cache directory| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#29160   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | tbd.<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------2e14b6e [WebServerBundle] Change the default pidfile location to cache directory
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
@jschaedljschaedl deleted the web-server-bundle_store-pidfile-project-dir branchFebruary 23, 2020 08:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh requested changes

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@jschaedl@nicolas-grekas@fabpot@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp