Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translator] Dump native plural formats to po files#31269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromStadly:dump-po-plurals
Jul 8, 2019
Merged

[Translator] Dump native plural formats to po files#31269

fabpot merged 1 commit intosymfony:4.4fromStadly:dump-po-plurals
Jul 8, 2019

Conversation

@Stadly
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29963,#10152
LicenseMIT
Doc PR

Implementing support for dumping to the native po plural format.

'foo|foos' => 'bar|bars'

Before, the entry above was dumped directly:

msgid "foo|foos"msgstr "bar|bars"

With this PR, it is dumped using the native po plural format:

msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"

Strings using explicit rules or contain more than 2 pluralization forms are still dumped directly, as the po format does not support such cases:

'{0} no foos|one foo|%count% foos' => '{0} no bars|one bar|%count% bars'
msgid "{0} no foos|one foo|%count% foos"msgstr "{0} no bars|one bar|%count% bars"

This PR complements#31266, fixing loading of native po plural formats.

@Stadly
Copy link
ContributorAuthor

I don't think the failing builds has anything to do with this PR.

@StadlyStadly changed the titleDump native plural formats to po files[Translator] Dump native plural formats to po filesApr 26, 2019
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 27, 2019
@Stadly
Copy link
ContributorAuthor

Is there anything I can do to help this make it into version 4.3?#31266 should be merged first, at least, as dumping something that is not loaded correctly doesn't make sense.

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for 4.4

@fabpotfabpot changed the base branch frommaster to4.4July 8, 2019 08:26
@fabpot
Copy link
Member

Thank you@Stadly.

@fabpotfabpot merged commitdc31739 intosymfony:4.4Jul 8, 2019
fabpot added a commit that referenced this pull requestJul 8, 2019
…tadly)This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes#31269).Discussion----------[Translator] Dump native plural formats to po files| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29963,#10152| License       | MIT| Doc PR        |Implementing support for dumping to the native po plural format.```'foo|foos' => 'bar|bars'```Before, the entry above was dumped directly:```msgid "foo|foos"msgstr "bar|bars"```With this PR, it is dumped using the native po plural format:```msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"```Strings using explicit rules or contain more than 2 pluralization forms are still dumped directly, as the po format does not support such cases:```'{0} no foos|one foo|%count% foos' => '{0} no bars|one bar|%count% bars'``````msgid "{0} no foos|one foo|%count% foos"msgstr "{0} no bars|one bar|%count% bars"```This PR complements#31266, fixing loading of native po plural formats.Commits-------dc31739 [Translator] Dump native plural formats to po files
@StadlyStadly deleted the dump-po-plurals branchJuly 22, 2019 09:38
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Stadly@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp