Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translator] Dump native plural formats to po files#31269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Stadly commentedApr 26, 2019
I don't think the failing builds has anything to do with this PR. |
Stadly commentedMay 9, 2019
Is there anything I can do to help this make it into version 4.3?#31266 should be merged first, at least, as dumping something that is not loaded correctly doesn't make sense. |
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for 4.4
fabpot commentedJul 8, 2019
Thank you@Stadly. |
…tadly)This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes#31269).Discussion----------[Translator] Dump native plural formats to po files| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29963,#10152| License | MIT| Doc PR |Implementing support for dumping to the native po plural format.```'foo|foos' => 'bar|bars'```Before, the entry above was dumped directly:```msgid "foo|foos"msgstr "bar|bars"```With this PR, it is dumped using the native po plural format:```msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"```Strings using explicit rules or contain more than 2 pluralization forms are still dumped directly, as the po format does not support such cases:```'{0} no foos|one foo|%count% foos' => '{0} no bars|one bar|%count% bars'``````msgid "{0} no foos|one foo|%count% foos"msgstr "{0} no bars|one bar|%count% bars"```This PR complements#31266, fixing loading of native po plural formats.Commits-------dc31739 [Translator] Dump native plural formats to po files
Implementing support for dumping to the native po plural format.
Before, the entry above was dumped directly:
With this PR, it is dumped using the native po plural format:
Strings using explicit rules or contain more than 2 pluralization forms are still dumped directly, as the po format does not support such cases:
This PR complements#31266, fixing loading of native po plural formats.