Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translator] Load plurals from po files properly#31266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromStadly:load-po-plurals
Jul 8, 2019
Merged

[Translator] Load plurals from po files properly#31266

fabpot merged 1 commit intosymfony:3.4fromStadly:load-po-plurals
Jul 8, 2019

Conversation

@Stadly
Copy link
Contributor

@StadlyStadly commentedApr 26, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#10152 (comment)
LicenseMIT
Doc PR

Plurals were not handled correctly when loading po files.

msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"

Before, the po entry above was treated as two entries, which doesn't make sense:

'foo' => 'bar''foos' => 'bar|bars'

With this PR, it is treated as one entry:

'foo|foos' => 'bar|bars'

@StadlyStadly changed the titleLoad plurals from po files properly[Translator] Load plurals from po files properlyApr 26, 2019
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneApr 27, 2019
@fabpot
Copy link
Member

Thank you@Stadly.

@fabpotfabpot merged commit6b69a99 intosymfony:3.4Jul 8, 2019
fabpot added a commit that referenced this pull requestJul 8, 2019
This PR was squashed before being merged into the 3.4 branch (closes#31266).Discussion----------[Translator] Load plurals from po files properly| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#10152 (comment)| License       | MIT| Doc PR        |Plurals were not handled correctly when loading po files.```msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"```Before, the po entry above was treated as two entries, which doesn't make sense:```'foo' => 'bar''foos' => 'bar|bars'```With this PR, it is treated as one entry:```'foo|foos' => 'bar|bars'```Commits-------6b69a99 [Translator] Load plurals from po files properly
fabpot added a commit that referenced this pull requestJul 8, 2019
This PR was merged into the 3.4 branch.Discussion----------[Translator] Load plurals from mo files properly| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#10152 (comment)| License       | MIT| Doc PR        |Plurals were not handled correctly when loading mo files.```msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"```Before, the mo entry above was treated as two entries, which doesn't make sense:```'foo' => 'bar''foos' => '{0} bar|{1} bars'```With this PR, it is treated as one entry:```'foo|foos' => 'bar|bars'```This PR does the same as#31266, just for mo files instead of po files. Note, however, that the old behavior differed between po and mo files: `'foos' => 'bar|bars'` for po files and `'foos' => '{0} bar|{1} bars'` for mo files.Commits-------97d28b5 Load plurals from mo files properly
fabpot added a commit that referenced this pull requestJul 8, 2019
…tadly)This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes#31269).Discussion----------[Translator] Dump native plural formats to po files| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29963,#10152| License       | MIT| Doc PR        |Implementing support for dumping to the native po plural format.```'foo|foos' => 'bar|bars'```Before, the entry above was dumped directly:```msgid "foo|foos"msgstr "bar|bars"```With this PR, it is dumped using the native po plural format:```msgid "foo"msgid_plural "foos"msgstr[0] "bar"msgstr[1] "bars"```Strings using explicit rules or contain more than 2 pluralization forms are still dumped directly, as the po format does not support such cases:```'{0} no foos|one foo|%count% foos' => '{0} no bars|one bar|%count% bars'``````msgid "{0} no foos|one foo|%count% foos"msgstr "{0} no bars|one bar|%count% bars"```This PR complements#31266, fixing loading of native po plural formats.Commits-------dc31739 [Translator] Dump native plural formats to po files
@StadlyStadly deleted the load-po-plurals branchJuly 22, 2019 09:28
This was referencedJul 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Stadly@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp