Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Update timezones to ICU 64.2 + compile zone to country mapping#31262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jakzal commentedApr 26, 2019
Nice, I was waiting for the 3.4 merge to master. Make sure |
ro0NL commentedApr 28, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
this ones ready, see last commit for the added timezones which are missing currently (cc@fabpot) cc@sstok tests are passing 👍 The main change is we use Also a fallback was missing for e.g. I think this nails it, and im done with timezones for a while now 😆 |
fabpot commentedApr 29, 2019
@ro0NL Is it desired that we have a trailing white space in |
src/Symfony/Component/Intl/Data/Generator/TimezoneDataGenerator.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ro0NL commentedApr 29, 2019
@fabpot not sure :) all json files (en.json, composer.json) have trailing EOL; there are no parsing issues AFAIK. Unless you meant a different whitespace? If it's about e.g.https://github.com/symfony/symfony/pull/31262/files#diff-5996b6b88384d2b755c17f069229882fR4 that's part of the localized interpunction; it's UTF :) |
fabpot commentedApr 29, 2019
Thank you@ro0NL. |
…country mapping (ro0NL)This PR was squashed before being merged into the 4.3-dev branch (closes#31262).Discussion----------[Intl] Update timezones to ICU 64.2 + compile zone to country mapping| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->This PR compiles the zone to country mapping (and vice versa) from ICU data:https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/windowsZones.txtI've recompiled timezones on master due#31162, i should do it once more when it's merged upstream.Having this data allows compatibility between PHP timezones and ICU;-https://www.php.net/manual/en/intltimezone.getregion.php-https://www.php.net/manual/en/class.datetimezone.php#datetimezone.constants.per-countryFor the timezone validator in Symfony, this would be required to have a compatible "regions" option, once it supports ICU as well (#28836 (comment))Commits-------3018a7a [Intl] Update timezones to ICU 64.2 + compile zone to country mapping
This PR compiles the zone to country mapping (and vice versa) from ICU data:
https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/windowsZones.txt
I've recompiled timezones on master due#31162, i should do it once more when it's merged upstream.
Having this data allows compatibility between PHP timezones and ICU;
For the timezone validator in Symfony, this would be required to have a compatible "regions" option, once it supports ICU as well (#28836 (comment))