Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DomCrawler] fix HTML5 parser integration#31257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromnicolas-grekas:dow-html5
May 9, 2019

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Spotted while reviewing#30892
The current logic is context-dependent: by changing the order of calls, you can get different behaviors.

@stof
Copy link
Member

stof commentedApr 26, 2019•
edited
Loading

I don't understand which issue you are trying to solve here.

We cannot add content multiple time (as all nodes have to belong to the same document), and calling->html() before adding content does not make sense and will not reach this code anyway.

@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedMay 5, 2019•
edited
Loading

I don't understand which issue you are trying to solve here.

The code makes little sense either: one should not have to know how the overall class works to understand local details. I'm making the code have a better locality so one can reason about it in a simpler way.

@nicolas-grekasnicolas-grekas changed the base branch frommaster to4.3May 9, 2019 14:02
@nicolas-grekasnicolas-grekas merged commitba83bda intosymfony:4.3May 9, 2019
nicolas-grekas added a commit that referenced this pull requestMay 9, 2019
This PR was merged into the 4.3 branch.Discussion----------[DomCrawler] fix HTML5 parser integration| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Spotted while reviewing#30892The current logic is context-dependent: by changing the order of calls, you can get different behaviors.Commits-------ba83bda [DomCrawler] fix HTML5 parser integration
@nicolas-grekasnicolas-grekas deleted the dow-html5 branchMay 21, 2019 08:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

+1 more reviewer

@jakzaljakzaljakzal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@stof@jakzal@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp