NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translator] Set sources when extracting strings from php files#31249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromStadly:extract-sources-php

May 7, 2019

Merged

[Translator] Set sources when extracting strings from php files#31249

fabpot merged 1 commit intosymfony:masterfromStadly:extract-sources-php

May 7, 2019

Conversation

Copy link

Contributor

Stadly commentedApr 25, 2019

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Set metadata about filenames and line numbers when extracting translatable strings from php files. This PR complements#30909 and#31248, as those PRs implement support for dumping the filenames and line numbers to Po and Qt file formats.

carsonbot added Status: Needs Review Translation Feature labels

Apr 25, 2019

Copy link

ContributorAuthor

Stadly commentedApr 25, 2019

I don't understand why the test is failing on PHP7.3 I've tested with PHP7.3 locally, and it works fine. Can it have something to do withdeps=low?

nicolas-grekas added this to thenext milestone

Apr 26, 2019

nicolas-grekas reviewed

Apr 26, 2019

View reviewed changes

src/Symfony/Component/Translation/Extractor/PhpExtractor.php OutdatedShow resolvedHide resolved

fabpot requested changes

Apr 29, 2019

View reviewed changes

src/Symfony/Component/Translation/Tests/Extractor/PhpExtractorTest.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Apr 29, 2019

fabpot approved these changes

Apr 29, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Apr 29, 2019

fabpot reviewed

Apr 29, 2019

View reviewed changes

src/Symfony/Component/Translation/Tests/Extractor/PhpExtractorTest.php OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

Stadly commentedApr 29, 2019

I don't think the failing build has anything to do with this PR.

carsonbot removed the Status: Reviewed label

May 1, 2019

fabpot requested changes

May 1, 2019

View reviewed changes

src/Symfony/Component/Translation/Tests/Extractor/PhpExtractorTest.php OutdatedShow resolvedHide resolved

carsonbot added the Status: Needs Work label

May 1, 2019

Copy link

Member

fabpot commentedMay 2, 2019

@Stadly I see that yo merge a branch here. Can you rebase to get rid of the merge commit?

fabpot requested changes

May 2, 2019

View reviewed changes

src/Symfony/Component/Translation/Extractor/PhpExtractor.phpShow resolvedHide resolved

src/Symfony/Component/Translation/Tests/Extractor/PhpExtractorTest.php OutdatedShow resolvedHide resolved

Stadly requested review fromdunglas,sroze andxabbuh ascode owners

May 2, 2019 07:22

carsonbot added Status: Needs Review and removed Status: Needs Work labels

May 2, 2019

Copy link

ContributorAuthor

Stadly commentedMay 2, 2019

Haha. I'm messing up everything. I'll try to fix it :)

carsonbot removed the Status: Needs Review label

May 2, 2019

fabpot approved these changes

May 2, 2019

View reviewed changes

carsonbot added the Status: Reviewed label

May 2, 2019

Copy link

Member

fabpot commentedMay 2, 2019

One last question about this PR: we set the filename as an absolute path. Is it useful? Wouldn't it be "better" to use a relative path? I'm not sure what the spec says about this.

Copy link

ContributorAuthor

Stadly commentedMay 2, 2019

The path used when extracting is the one set as source, so whether it is absolute or relative depends on the user.extract(__DIR__.'/../src/') will give absolute paths, whileextract('../src/') will give relative paths.

Copy link

ContributorAuthor

Stadly commentedMay 2, 2019

Should I add a test using relative paths?

[Translator] Set sources when extracting strings from php files

f05d4e4

Copy link

Member

fabpot commentedMay 7, 2019

Thank you@Stadly.

fabpot merged commitf05d4e4 intosymfony:master

May 7, 2019

fabpot added a commit that referenced this pull request

May 7, 2019

feature#31249[Translator] Set sources when extracting strings from …

b2f5b8a

…php files (Stadly)This PR was squashed before being merged into the 4.3-dev branch (closes#31249).Discussion----------[Translator] Set sources when extracting strings from php files| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Set metadata about filenames and line numbers when extracting translatable strings from php files. This PR complements#30909 and#31248, as those PRs implement support for dumping the filenames and line numbers to Po and Qt file formats.Commits-------f05d4e4 [Translator] Set sources when extracting strings from php files

Stadly deleted the extract-sources-php branch

May 7, 2019 12:15

fabpot mentioned this pull request

May 9, 2019

Release v4.3.0-BETA1#31435

Merged