Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix name and phpdoc of ContainerBuilder::removeBindings#31173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromteohhanhui:patch-3
Apr 27, 2019

Conversation

@teohhanhui
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29944 (comment)
LicenseMIT
Doc PRN/A

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneApr 18, 2019
@teohhanhuiteohhanhui changed the titleFix phpoc param type for ContainerBuilder::addRemovedBindingIdsFix name and phpdoc of ContainerBuilder::addRemovedBindingIdApr 18, 2019
@teohhanhui
Copy link
ContributorAuthor

The method name was also wrong. It's okay to change because it's@internal.

OskarStark reacted with thumbs up emoji

@teohhanhuiteohhanhui changed the titleFix name and phpdoc of ContainerBuilder::addRemovedBindingIdFix name and phpdoc of ContainerBuilder::removeBindingsApr 20, 2019
@fabpot
Copy link
Member

Even if the method is marked as internal, we won't rename the method in 3.4 as this is not a bug fix. So, the phpdoc can be merged in 3.4, but the rest should be done in master.

Simperfit reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

These methods have been released for the 1st time 10 days ago, see#29944
I think we can/should change them in 3.4.

teohhanhui and xabbuh reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@teohhanhui.

teohhanhui reacted with hooray emojiteohhanhui reacted with rocket emoji

@nicolas-grekasnicolas-grekas merged commitc93194d intosymfony:3.4Apr 27, 2019
nicolas-grekas added a commit that referenced this pull requestApr 27, 2019
…(teohhanhui)This PR was merged into the 3.4 branch.Discussion----------Fix name and phpdoc of ContainerBuilder::removeBindings| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29944 (comment)| License       | MIT| Doc PR        | N/A<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------c93194d Fix name and phpdoc of ContainerBuilder::removeBindings
@teohhanhuiteohhanhui deleted the patch-3 branchApril 27, 2019 09:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@teohhanhui@fabpot@nicolas-grekas@stof@OskarStark@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp