Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] [Validator] Legacy Translator Checking#31154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "symfony/polyfill-ctype":"~1.8", | ||
| "symfony/polyfill-mbstring":"~1.0" | ||
| "symfony/polyfill-mbstring":"~1.0", | ||
| "symfony/translation":"~4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I moved this into therequire section sinceLegacyTranslatorProxy includes a reference still to the old interface.
nicolas-grekas commentedApr 18, 2019
Thanks, but I don't understand why all these changes. This reintroduces the bug that is fixed by#31108 I feel like the only needed change is moving translation to the require section, isn't it? |
xabbuh commentedApr 18, 2019
see#31156 for an easier alternative solution |
This fixes the recent bug that was introduced in 4.2.7 with regard to the old TranslatorInterface being passed to the LegacyTranslatorProxy decorator, which isn't compatible.
ping@nicolas-grekas since you were looking for this