NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"#31142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromchalasr:revert-30423

Apr 17, 2019

Merged

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"#31142

fabpot merged 1 commit intosymfony:3.4fromchalasr:revert-30423

Apr 17, 2019

Conversation

Copy link

Member

chalasr commentedApr 17, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31136
License	MIT
Doc PR	n/a

Revert "bugsymfony#30423[Security] Rework firewall's access denied …

cd77f6f

…rule (dimabory)"This reverts commitfd1408b, reversingchanges made tob93d2bf.

chalasr added the Security label

Apr 17, 2019

chalasr added this to the3.4 milestone

Apr 17, 2019

carsonbot added Status: Needs Review Bug labels

Apr 17, 2019

Copy link

Contributor

curry684 commentedApr 17, 2019

So idea is to push this to 3.4 and 4.2 but not master right? Or should we just delay the real fix until 5.0 is branched?

Copy link

Member

fabpot commentedApr 17, 2019

I'm fine with having it in master/4.3.

Copy link

Contributor

curry684 commentedApr 17, 2019

Yes so we agree the revert should only be in 3.4 and 4.2, and the fix stays in master/4.3 indeed 😄

chalasr mentioned this pull request

Apr 17, 2019

[3.4.25][BC Break] 403 instead of 401 for unauthorized users#31136

Closed

Copy link

Member

fabpot commentedApr 17, 2019

We will need a new PR for master though.

Copy link

Contributor

dimabory commentedApr 17, 2019

We will need a new PR for master though.

@fabpot Should I take over this as an author of#30423?

Copy link

Contributor

curry684 commentedApr 17, 2019

You could just resubmit the same PR with the upgrade and changelog notes that will be needed now.

Copy link

MemberAuthor

chalasr commentedApr 17, 2019

@dimabory PR welcome with UPGRADE + CHANGELOG entries

Copy link

Contributor

dimabory commentedApr 17, 2019

@curry684,@chalasr Actually, the discussion can be moved to#30423 (someone is still commenting there)

JarJak mentioned this pull request

Apr 17, 2019

[Security] Rework firewall's access denied rule#30423

Merged

fabpot merged commitcd77f6f intosymfony:3.4

Apr 17, 2019

fabpot pushed a commit that referenced this pull request

Apr 17, 2019

bug#31142Revert "bug#30423[Security] Rework firewall's access den…

55a21fb

…ied rule (dimabory)" (chalasr)This PR was merged into the 3.4 branch.Discussion----------Revert "bug#30423 [Security] Rework firewall's access denied rule (dimabory)"| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? |no| Tests pass?   | yes| Fixed tickets |#31136| License       | MIT| Doc PR        | n/aCommits-------cd77f6f Revert "bug#30423 [Security] Rework firewall's access denied rule (dimabory)"