Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] Dispatch an event when "logout user on change" steps in#31138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedApr 17, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#26902
LicenseMIT
Doc PRsymfony/symfony-docs#11450

This adds a new event when the user has been changed and has been log out from the apps, it allow someone to register to this event and do something with either to token or the refreshedUser.

@SimperfitSimperfitforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch 2 times, most recently from1396daf to452978aCompareApril 17, 2019 07:05
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 17, 2019
@SimperfitSimperfitforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch 2 times, most recently from1129413 to8f767eeCompareApril 18, 2019 04:50
@SimperfitSimperfit marked this pull request as ready for reviewApril 18, 2019 04:51
Copy link
Contributor

@linaorilinaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great idea!

@SimperfitSimperfitforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch from8f767ee to36bb3b2CompareApril 18, 2019 14:34
@Simperfit
Copy link
ContributorAuthor

Status: Needs Review

@SimperfitSimperfitforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch from36bb3b2 tob6ad28aCompareApril 18, 2019 14:44
@Simperfit
Copy link
ContributorAuthor

Status: Needs Review

@SimperfitSimperfitforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch fromb6ad28a to5765f69CompareApril 18, 2019 14:44
@Simperfit
Copy link
ContributorAuthor

Thanks@linaori and@noniagriconomie for the review !

@noniagriconomie
Copy link
Contributor

noniagriconomie commentedApr 18, 2019
edited
Loading

@Simperfit do not forget to update the doc accordingly when PR is finished :)
https://github.com/symfony/symfony-docs/pull/11450/files#diff-2f19b023cc3b9935394ee5a983d40cdcR286

Simperfit reacted with thumbs up emoji

@chalasrchalasrforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch 2 times, most recently from95f1071 toecdeab8CompareApril 26, 2019 21:16
@chalasr
Copy link
Member

Reverted my suggestion about allowing to reauthenticate the token from a listener, bad idea. Also renamed toDeauthenticatedEvent to save us from renaming the event in 5.0 as we want to get rid of theUser concept (#30914).
Ready to go 👍

@xabbuh
Copy link
Member

If we also do not want to rely on the user concept, would it make sense to pass the old and the refreshed token instead of the user?

linaori and chalasr reacted with thumbs up emoji

@chalasrchalasrforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch 2 times, most recently fromb901b0b toabec9c1CompareApril 27, 2019 13:38
@chalasr
Copy link
Member

@xabbuh 👍 Changed togetOriginalToken() andgetDeauthenticatedToken().
Wording suggestions welcome (getRefreshedToken() vsgetDeauthenticatedToken()?)

@Simperfit
Copy link
ContributorAuthor

I likegetRefreshedToken() better :p

@chalasrchalasrforce-pushed thefeature/add-a-new-event-when-the-user-has-been-logout-on-change branch fromabec9c1 to40e4218CompareApril 27, 2019 14:12
@chalasr
Copy link
Member

chalasr commentedApr 27, 2019
edited
Loading

Renamed

Simperfit reacted with thumbs up emoji

@Simperfit
Copy link
ContributorAuthor

Thanks for helping me finishing this@chalasr ;).

chalasr reacted with thumbs up emoji

@chalasr
Copy link
Member

Thank you@Simperfit.

Simperfit reacted with thumbs up emoji

@chalasrchalasr merged commit40e4218 intosymfony:masterApr 28, 2019
chalasr pushed a commit that referenced this pull requestApr 28, 2019
…ge" steps in (Simperfit)This PR was merged into the 4.3-dev branch.Discussion----------[Security] Dispatch an event when "logout user on change" steps in| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#26902   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |symfony/symfony-docs#11450 <!-- required for new features --><!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This adds a new event when the user has been changed and has been log out from the apps, it allow someone to register to this event and do something with either to token or the refreshedUser.Commits-------40e4218 [Security] Dispatch an event when "logout user on change" steps in
@SimperfitSimperfit deleted the feature/add-a-new-event-when-the-user-has-been-logout-on-change branchApril 28, 2019 16:51
* Dispatch`SwitchUserEvent` on`security.switch_user`
* Deprecated`Argon2iPasswordEncoder`, use`SodiumPasswordEncoder` instead
* Deprecated`BCryptPasswordEncoder`, use`NativePasswordEncoder` instead
* Added`DeauthenticatedEvent` dispatched in case the user has changed when trying to refresh it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is "it" here? The user?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think "it" refers to the Token here. What about "AddedDeauthenticatedEvent dispatched in case the user has changed when trying to refresh the token"?

useSymfony\Contracts\EventDispatcher\Event;

/**
* Deauthentication happens in case the user has changed when trying to refresh it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sentence should be changed as well

@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestMay 7, 2019
…" steps in (Simperfit)This PR was merged into the master branch.Discussion----------[Security] Dispatch an event when "logout user on change" steps in<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->This documents the new event implemented insymfony/symfony#31138Commits-------b5e6038 [Security] Dispatch an event when "logout user on change" steps in
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@chalasrchalasrchalasr approved these changes

@xabbuhxabbuhxabbuh approved these changes

+3 more reviewers

@noniagriconomienoniagriconomienoniagriconomie left review comments

@aschemppaschemppaschempp requested changes

@linaorilinaorilinaori approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

9 participants

@Simperfit@noniagriconomie@nicolas-grekas@chalasr@aschempp@xabbuh@fabpot@linaori@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp