Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] decorate the ValidatorBuilder's translator with LegacyTranslatorProxy#31108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
01b2963 toa12656eComparesnebes approved these changesApr 15, 2019
snebes left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change corrects the error I was getting. Thank you!
joseneto29 approved these changesApr 15, 2019
Simperfit approved these changesApr 16, 2019
chalasr approved these changesApr 16, 2019
fabpot pushed a commit that referenced this pull requestApr 17, 2019
…or with LegacyTranslatorProxy (nicolas-grekas)This PR was merged into the 4.2 branch.Discussion----------[FrameworkBundle] decorate the ValidatorBuilder's translator with LegacyTranslatorProxy| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31092,#31025| License | MIT| Doc PR | -This allows defining a translator that implements only the new interface and use it with ValidatorBuilder.ping@dvdknaap,@snebes since you were affected.Commits-------a12656e [FrameworkBundle] decorate the ValidatorBuilder's translator with LegacyTranslatorProxy
Merged
Contributor
Gemorroj commentedApr 17, 2019
"require": {"php":"^7.2","ext-ctype":"*","ext-iconv":"*","ext-apcu":"*","ext-pdo_pgsql":"*","ext-curl":"*","ext-json":"*","ext-soap":"*","ext-intl":"*","symfony/console":"4.2.*","symfony/dotenv":"4.2.*","symfony/flex":"^1.1","symfony/framework-bundle":"4.2.*","symfony/yaml":"4.2.*","symfony/orm-pack":"*","symfony/validator":"4.2.*","symfony/security-bundle":"4.2.*","symfony/intl":"4.2.*","symfony/form":"4.2.*","symfony/serializer":"4.2.*","symfony/monolog-bundle":"^3.3","misd/phone-number-bundle":"^2.0@dev","nelmio/api-doc-bundle":"^3.4","nelmio/cors-bundle":"^1.5","lexik/jwt-authentication-bundle":"^2.6","martin-georgiev/postgresql-for-doctrine":"^1.1","fresh/doctrine-enum-bundle":"^6.2","barbieswimcrew/zip-code-validator":"^1.3","symfony/swiftmailer-bundle":"^3.2","symfony/twig-bundle":"4.2.*","shapecode/cron-bundle":"^3.2.3","pagerfanta/pagerfanta":"^2.0","wsdltophp/packagegenerator":"^3.2","wsdltophp/wssecurity":"^1.2" },"require-dev": {"symfony/maker-bundle":"^1.7","symfony/debug-bundle":"4.2.*","easycorp/easy-log-handler":"^1.0.5","phpstan/phpstan-symfony":"^0.10","phpstan/phpstan-phpunit":"^0.10","friendsofphp/php-cs-fixer":"^2.13" }, after update |
Contributor
Gemorroj commentedApr 17, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
temporary add to requirements |
leonexcc commentedApr 17, 2019
This breaks Contao (https://github.com/contao/contao) 4.7.4 in combination with symfony/validator (v4.2.7): The Contao translator still implements the legacy interface and is blindly wrapped into the proxy. With symfony/framework-bundle v4.2.6 everything workes fine. |
MemberAuthor
nicolas-grekas commentedApr 17, 2019
See#31152 |
sdaoudi commentedApr 17, 2019
Thanks@nicolas-grekas |
This was referencedApr 18, 2019
sheeep pushed a commit to sheeep/conflicts that referenced this pull requestApr 18, 2019
leofeyer pushed a commit to contao/conflicts that referenced this pull requestApr 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows defining a translator that implements only the new interface and use it with ValidatorBuilder.
ping@dvdknaap,@snebes since you were affected.