Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr#31102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
AngelFQC wants to merge1 commit intosymfony:masterfromAngelFQC:patch-1

Conversation

@AngelFQC
Copy link
Contributor

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets...
LicenseMIT
Doc PR...

Bootstrap provides a way to translate the “Browse” text in HTML with the data-browse attribute which can be added to the custom input label.

https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-html

But currently the attributes declared in label_attr aren't being added.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(for 4.2?)

@nicolas-grekasnicolas-grekas changed the titleBS4 File layout: Allow set label attributes declared in label_attr[TwigBridge] bootstrap4 file_widget: Allow set label attributes declared in label_attrApr 15, 2019
@nicolas-grekasnicolas-grekas changed the title[TwigBridge] bootstrap4 file_widget: Allow set label attributes declared in label_attr[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attrApr 15, 2019
@AngelFQCAngelFQC changed the base branch frommaster to4.2April 17, 2019 22:22
@AngelFQCAngelFQC changed the base branch from4.2 tomasterApril 17, 2019 22:22
fabpot added a commit that referenced this pull requestApr 27, 2019
…el attributes declared in label_attr (AngelFQC)This PR was submitted for the 4.2 branch but it was merged into the 4.3-dev branch instead (closes#31220).Discussion----------[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr| Q             | A| ------------- | ---| Branch?       | 4.2 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | ...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | ... <!-- required for new features -->> Bootstrap provides a way to translate the “Browse” text in HTML with the data-browse attribute which can be added to the custom input label.https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-htmlBut currently the attributes declared in label_attr aren't being added.Previously I sent this same change to the master branch (PR#31102), but I think I should have sent it to branch 4.2Commits-------9c76b29 [TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@AngelFQC@nicolas-grekas@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp