i think it's intended to still render errors here, which is up for debate in general i believe :)

To show the error inside the label as well?

Could you suggest another way to not show the<label> when it was set to false?

To show the error inside the label as well?

Yep :) see#24435,#26167

cc@Nyholm

Make sure errors are a part of the label on bootstrap 4 - this is a requirement for WCAG2

Ok clear 👍 Let's make sure that rule gets preserved. Then the question would be whether a label still should get rendered even whenfalse gets passed.

The use-case here is that we want to render a custom label, while we want to keep using the Bootstrap theme for rendering the widget.

The problem is that{{ form_widget(} }} does render both the widget and the label. By passingfalse we basically say that userland is responsible for complying to the WCAG2 that the error should be rendered inside the label.

i once suggested to make the split explicit, i.e.form_label +form_label_with_errors

{{ form_widget(} }} does render both the widget and the label

this sounds like a violation of concerns already :)

im not sure what path to take. I agree a user could be responsible, and IMHO SF should provide low-level building blocks for it.

Can't we fix the initial point for now? Display the label if there are errors?

Both when a value orfalse is passed forlabel the errors do get rendered. Rendering the errors in the label according to WCAG2 should get preserved.

The problem for userlandChoiceType implementations; whenlabel => false is passed, the label value does not get rendered while the<label> tag does get rendered.

So the change I suggest via this PR is to also not render the<label> tag whenfalse is passed. The error message will then bubble up to the parent (that also complies to WCAG2).

Are you sure that errors bubble up?

friendly ping@rvanlaak

Have been working on a unit test to verify this, but did not manage to complete that yet.