NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] Show all option normalizers on debug:form command#31082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromyceruto:debug_form_option_normalizers

Apr 15, 2019

Merged

[Form] Show all option normalizers on debug:form command#31082

fabpot merged 1 commit intosymfony:masterfromyceruto:debug_form_option_normalizers

Apr 15, 2019

Conversation

Copy link

Member

yceruto commentedApr 11, 2019

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT

Follow-up#30371

carsonbot added Status: Needs Review Form Feature labels

Apr 11, 2019

yceruto force-pushed thedebug_form_option_normalizers branch 3 times, most recently from713fdc6 to90bc7f7Compare

April 11, 2019 22:38

yceruto requested a review fromxabbuh as acode owner

April 11, 2019 22:38

xabbuh added this to thenext milestone

Apr 12, 2019

xabbuh reviewed

Apr 12, 2019

View reviewed changes

src/Symfony/Component/Form/Tests/Command/DebugCommandTest.phpShow resolvedHide resolved

Copy link

Contributor

OskarStark commentedApr 12, 2019

A bit of topic but as you are on it... In the Allowed types section shouldn’t it be null without quotes? 🤔

Copy link

MemberAuthor

yceruto commentedApr 12, 2019•
edited
Loading

Hi@OskarStark, the output is consistent with its definition, we pass'null' as allowed type:

symfony/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php

Line 43 in572864b

$resolver->setAllowedTypes('query_builder', ['null','callable','Doctrine\ORM\QueryBuilder']);

Show all option normalizers on debug:form command

f1d3bc0

yceruto force-pushed thedebug_form_option_normalizers branch from90bc7f7 tof1d3bc0Compare

April 15, 2019 13:16

Copy link

MemberAuthor

yceruto commentedApr 15, 2019•
edited
Loading

Rebased and conflict fixed

carsonbot removed the Status: Needs Review label

Apr 15, 2019

fabpot approved these changes

Apr 15, 2019

View reviewed changes

carsonbot added the Status: Reviewed label

Apr 15, 2019

Copy link

Member

fabpot commentedApr 15, 2019

Thank you@yceruto.

fabpot merged commitf1d3bc0 intosymfony:master

Apr 15, 2019

fabpot added a commit that referenced this pull request

Apr 15, 2019

feature#31082[Form] Show all option normalizers on debug:form comma…

7cf96a4

…nd (yceruto)This PR was merged into the 4.3-dev branch.Discussion----------[Form] Show all option normalizers on debug:form command| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MITFollow-up#30371![normalizers](https://user-images.githubusercontent.com/2028198/55996454-6667df80-5c85-11e9-94f6-9ee3988833f3.png)Commits-------f1d3bc0 Show all option normalizers on debug:form command

yceruto deleted the debug_form_option_normalizers branch

April 15, 2019 22:09