Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Fixed LoggerDataCollector crashing on empty file#31076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromalthaus:31050-fix-logger-data-collectorApr 11, 2019
Merged
[HttpKernel] Fixed LoggerDataCollector crashing on empty file#31076
nicolas-grekas merged 1 commit intosymfony:3.4fromalthaus:31050-fix-logger-data-collectorApr 11, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(for 3.4)
nicolas-grekas approved these changesApr 11, 2019
9fded1f to291c73aCompareMember
nicolas-grekas commentedApr 11, 2019
Thank you@althaus. |
nicolas-grekas added a commit that referenced this pull requestApr 11, 2019
…ile (althaus)This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes#31076).Discussion----------[HttpKernel] Fixed LoggerDataCollector crashing on empty file| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31050| License | MITThis PR adds a check to the LoggerDataCollector if there's acutal some content in the log file.Commits-------291c73a Catch empty deprecation.log silently (fixes#31050)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file.