Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Improve test coverage from #30997#31042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromMikkelPaulson:fix-autocomplete-callback-test-coverageApr 10, 2019
Merged
Improve test coverage from #30997#31042
fabpot merged 1 commit intosymfony:masterfromMikkelPaulson:fix-autocomplete-callback-test-coverageApr 10, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Test coverage added in#30997 did a good job of validating previousbehaviour, but didn't adequately cover the new callback logic. Addedcoverage for new methods on the Question object.
fabpot approved these changesApr 10, 2019
Member
fabpot commentedApr 10, 2019
Thank you@MikkelPaulson. |
fabpot added a commit that referenced this pull requestApr 10, 2019
This PR was merged into the 4.3-dev branch.Discussion----------Improve test coverage from#30997| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes (test enhancement against change on master)| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | enhancement for#30997| License | MIT| Doc PR | N/ATest coverage added in#30997 did a good job of validating previous behaviour, but didn't adequately cover the new callback logic. Added coverage for new methods on the Question object.Commits-------4693422 Improve test coverage from#30997
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test coverage added in#30997 did a good job of validating previous behaviour, but didn't adequately cover the new callback logic. Added coverage for new methods on the Question object.