Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Deprecate calling createChildContext without the format parameter#31030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@dbu
Copy link
Contributor

@dbudbu commentedApr 9, 2019

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

as discussed in#30907 deprecate omitting the format parameter when extending the AbstractNormalizer.

@javiereguiluzjaviereguiluz changed the titledeprecate calling createChildContext without the format parameterDeprecate calling createChildContext without the format parameterApr 9, 2019
@dbudbu changed the titleDeprecate calling createChildContext without the format parameter[Serializer] Deprecate calling createChildContext without the format parameterApr 9, 2019
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 9, 2019
@dbudbuforce-pushed theserializer-cache-key-method-deprecation branch fromd5b0776 tofb73b72CompareApril 26, 2019 10:58
@dbu
Copy link
ContributorAuthor

dbu commentedApr 26, 2019

i updated to your comments@nicolas-grekas . okay like this?

@dbudbuforce-pushed theserializer-cache-key-method-deprecation branch 2 times, most recently fromea05e7b toda3411dCompareMay 15, 2019 09:18
@dbudbuforce-pushed theserializer-cache-key-method-deprecation branch fromda3411d to5363647CompareMay 15, 2019 09:55
@fabpotfabpot changed the base branch frommaster to4.3May 15, 2019 09:58
@fabpotfabpotforce-pushed theserializer-cache-key-method-deprecation branch from5363647 tocb77902CompareMay 15, 2019 09:58
@fabpot
Copy link
Member

Thank you@dbu.

@fabpotfabpot merged commitcb77902 intosymfony:4.3May 15, 2019
fabpot added a commit that referenced this pull requestMay 15, 2019
…out the format parameter (dbu)This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes#31030).Discussion----------[Serializer] Deprecate calling createChildContext without the format parameter| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -as discussed in#30907 deprecate omitting the format parameter when extending the AbstractNormalizer.Commits-------cb77902 deprecate calling createChildContext without the format parameter
@fabpotfabpot mentioned this pull requestMay 22, 2019
nicolas-grekas added a commit that referenced this pull requestJun 8, 2019
…anagi)This PR was merged into the 5.0-dev branch.Discussion----------[Serializer] Remove last deprecated/obsolete paths| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28316,#28709,#31030,#27020,#29896,16f8a13#r201060750   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A <!-- required for new features -->This should fix the last deprecations & obsolete code paths for the Serializer component.Commits-------c703b35 [Serializer] Remove last deprecated/obsolete paths
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas left review comments

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas requested changes

@fabpotfabpotfabpot approved these changes

+3 more reviewers

@joelwurtzjoelwurtzjoelwurtz left review comments

@jewome62jewome62jewome62 approved these changes

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

10 participants

@dbu@fabpot@dunglas@joelwurtz@nicolas-grekas@stof@jewome62@maxhelias@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp