Thisfixes#30996 and makes URL generation in the CLI context behave the same as it does in the web context where theLocaleListener sets the default locale (to the router context).

The Travis CI failure is related to the fact that the constraint forsymfony/routing should be bumped to^4.2.6 in the composer.json of the FrameworkBundle (when it gets tagged).

carsonbot added Status: Needs Review Routing Bug labels

Apr 8, 2019

X-Coder264 force-pushed thefix-route-url-generation-in-cli branch fromd005c8f to6faae44Compare

April 8, 2019 18:50

nicolas-grekas added this to the4.2 milestone

Apr 8, 2019

nicolas-grekas reviewed

Apr 8, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Routing/Router.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Apr 8, 2019

View reviewed changes

src/Symfony/Component/Routing/Router.php OutdatedShow resolvedHide resolved

Copy link

Member

nicolas-grekas commentedApr 8, 2019

the constraint for symfony/routing should be bumped to ^4.2.6 in the composer.json

please do it in this PR

nicolas-grekas reviewed

Apr 8, 2019

View reviewed changes

src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php OutdatedShow resolvedHide resolved

nicolas-grekas approved these changes

Apr 8, 2019

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with minor comments

src/Symfony/Bundle/FrameworkBundle/Routing/Router.php OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/Routing/RouterTest.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Routing/Router.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 8, 2019

X-Coder264 force-pushed thefix-route-url-generation-in-cli branch 2 times, most recently fromb9e3d03 to2cea5b6Compare

April 8, 2019 21:07

Copy link

Member

nicolas-grekas commentedApr 8, 2019

Tests will be green once the patch is merged up to master.

Copy link

Contributor

fancyweb commentedApr 9, 2019

I just tested the case I described in the linked ticket, and it does behave like I wrote it so this change could technically break someone workflow.

maxhelias approved these changes

Apr 9, 2019

View reviewed changes

Copy link

Member

nicolas-grekas commentedApr 15, 2019

@fancyweb the scenario you describe would apply to the cli but not to the web, right? Having a consistent behavior looks more important to me that preserving a non-consistent one to me. Makes sense?

Copy link

Contributor

fancyweb commentedApr 15, 2019

It also applies to the web context but I guess it's very unlikely that someone relies on this behavior.

fabpot approved these changes

Apr 22, 2019

View reviewed changes

[Routing] Fix route URL generation in CLI context

4a1ad4a

fabpot force-pushed thefix-route-url-generation-in-cli branch from2cea5b6 to4a1ad4aCompare

April 22, 2019 09:10

Copy link

Member

fabpot commentedApr 22, 2019

Thank you@X-Coder264.

fabpot merged commit4a1ad4a intosymfony:4.2

Apr 22, 2019

fabpot added a commit that referenced this pull request

Apr 22, 2019

bug#31023[Routing] Fix route URL generation in CLI context (X-Coder…

f50ffa9

…264)This PR was squashed before being merged into the 4.2 branch (closes#31023).Discussion----------[Routing] Fix route URL generation in CLI context| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30996| License       | MIT| Doc PR        | -Thisfixes#30996 and makes URL generation in the CLI context behave the same as it does in the web context where the `LocaleListener` sets the default locale (to the router context).The Travis CI failure is related to the fact that the constraint for `symfony/routing` should be bumped to `^4.2.6` in the composer.json of the FrameworkBundle (when it gets tagged).Commits-------4a1ad4a [Routing] Fix route URL generation in CLI context

X-Coder264 deleted the fix-route-url-generation-in-cli branch

April 22, 2019 09:20

Copy link

ContributorAuthor

X-Coder264 commentedApr 22, 2019•
edited
Loading

Thanks for the merge. Thesymfony/routing constraint forFrameworkBundle should be bumped now from^4.2.6 to^4.2.8 since 4.2.6 and 4.2.7 were already released since this PR was opened.

Copy link

Member

fabpot commentedApr 22, 2019

@X-Coder264 Thanks for the followup, fixed ine479b69

xabbuh mentioned this pull request

Apr 23, 2019

Twig path function fails for internationalized routes#30010

Closed

fabpot mentioned this pull request

May 1, 2019

Release v4.2.8#31347

Merged

X-Coder264 mentioned this pull request

Oct 30, 2019

[Routing] Fix URL generator instantiation#34192

Merged

nicolas-grekas added a commit that referenced this pull request

Nov 4, 2019

bug#34192[Routing] Fix URL generator instantiation (X-Coder264, Hyp…

a56ac78

…eMC)This PR was merged into the 4.3 branch.Discussion----------[Routing] Fix URL generator instantiation| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| License       | MITAfter merging my fix (PR#31023) from the 4.2 branch to 4.3 (which was master at the time) one code path which instantiates the url generator was missed. This new code path was added via#28865 and was missed during the merge because there was no merge conflict there as that code path didn't exist on 4.2.So the current state on the 4.3 branch is:-https://github.com/symfony/symfony/blob/v4.3.5/src/Symfony/Component/Routing/Router.php#L356 (default locale is properly passed to the constructor)-https://github.com/symfony/symfony/blob/v4.3.5/src/Symfony/Component/Routing/Router.php#L372 (default locale is **NOT** properly passed to the constructor)-https://github.com/symfony/symfony/blob/v4.3.5/src/Symfony/Component/Routing/Router.php#L378 (default locale is properly passed to the constructor)I noticed this in my app because tests started to fail on the branch where we are upgrading our app from SF 4.2 to 4.3 due to this. This PR fixes the inconsistency (now the default locale is passed on all three places) which fixes the bug.Commits-------9aa66e2 Add tests to ensure defaultLocale is properly passed to the URL generator16c9baf Fix URL generator instantiation