Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix the configurability of CoreExtension deps in standalone usage#30979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
| /** | ||
| * @param bool $forceCoreExtension | ||
| */ | ||
| publicfunction__construct($forceCoreExtension =false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
phpdoc should be replaced by a typehint when merging up to master
Uh oh!
There was an error while loading.Please reload this page.
f882444 to42111f0Compare42111f0 to934118bComparenicolas-grekas commentedApr 7, 2019
Thank you@stof. |
…e usage (stof)This PR was squashed before being merged into the 3.4 branch (closes#30979).Discussion----------Fix the configurability of CoreExtension deps in standalone usage| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | not yet, but will allow fixing them| Fixed tickets | n/a| License | MIT| Doc PR | n/aWhen using the Forms entrypoint to configure the component, there was no chance to configure dependencies of the CoreExtension, as the one registered without argument was first and would win.The builder now delays the prepending of the CoreExtension to do it only if the CoreExtension is not registered explicitly.We discovered that when trying to fix tests for the FileType, where we wanted to pass a Translator to it.Commits-------934118b Fix the configurability of CoreExtension deps in standalone usage
When using the Forms entrypoint to configure the component, there was no chance to configure dependencies of the CoreExtension, as the one registered without argument was first and would win.
The builder now delays the prepending of the CoreExtension to do it only if the CoreExtension is not registered explicitly.
We discovered that when trying to fix tests for the FileType, where we wanted to pass a Translator to it.