Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Add Argon2idPasswordEncoder#30968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromchalasr:argon2id
Apr 8, 2019

Conversation

@chalasr
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#28093
LicenseMIT
Doc PRTODO

Currently we have aArgon2iPasswordEncoder that may hash passwords usingargon2id instead ofargon2i (platform-dependent) which is not good.
This deprecates producing/validatingargon2id hashed passwords using theArgon2iPasswordEncoder, and adds aArgon2idPasswordEncoder able to produce/validateargon2id hashed passwords only.

#EUFOSSA

bocharsky-bw reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit0c82173 intosymfony:masterApr 8, 2019
fabpot added a commit that referenced this pull requestApr 8, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[Security] Add Argon2idPasswordEncoder| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#28093| License       | MIT| Doc PR        | TODOCurrently we have a `Argon2iPasswordEncoder` that may hash passwords using `argon2id` instead of `argon2i` (platform-dependent) which is not good.This deprecates producing/validating `argon2id` hashed passwords using the `Argon2iPasswordEncoder`, and adds a `Argon2idPasswordEncoder` able to produce/validate `argon2id` hashed passwords only.#EUFOSSACommits-------0c82173 [Security] Add Argon2idPasswordEncoder
@chalasrchalasr deleted the argon2id branchApril 8, 2019 14:42
publicfunctiontestEncodersWithArgon2id()
{
if (!Argon2idPasswordEncoder::isSupported()) {
$this->markTestSkipped('Argon2i algorithm is not supported.');
Copy link

@bigfoot90bigfoot90Apr 10, 2019•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Argon2id algorithm is not supported.

@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark requested changes

+3 more reviewers

@teohhanhuiteohhanhuiteohhanhui left review comments

@bigfoot90bigfoot90bigfoot90 left review comments

@sstoksstoksstok requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

9 participants

@chalasr@fabpot@stof@teohhanhui@sstok@OskarStark@bigfoot90@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp