Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Experimental for ObjectListExtractor#30963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@joelwurtz
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30904
LicenseMIT
Doc PR-

Related to#30818

I want to mark this class as@expiremental until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3

Mark alsofinal for the default implementation as we don't want that to be extendable and user should use composition over inheritance.

dmaicher reacted with thumbs up emoji
Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When the typos will be fixed.

@joelwurtzjoelwurtzforce-pushed thefeature/object-list-extractor-expiremental branch fromb6df430 tob0cdf45CompareApril 7, 2019 12:24
@joelwurtzjoelwurtz changed the title[Serializer] Expiremental for ObjectListExtractor[Serializer] Experimental for ObjectListExtractorApr 7, 2019
@nicolas-grekas
Copy link
Member

Thank you@joelwurtz.

@nicolas-grekasnicolas-grekas merged commitb0cdf45 intosymfony:masterApr 7, 2019
nicolas-grekas added a commit that referenced this pull requestApr 7, 2019
…lwurtz)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] Experimental for ObjectListExtractor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30904| License       | MIT| Doc PR        | -Related to#30818I want to mark this class as `@expiremental` until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3Mark also `final` for the default implementation as we don't want that to be extendable and user should use composition over inheritance.Commits-------b0cdf45 Set object list extractor as expiremental, and use final for default implementation
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
@joelwurtzjoelwurtz deleted the feature/object-list-extractor-expiremental branchAugust 14, 2023 20:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@joelwurtz@nicolas-grekas@dunglas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp