Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] [TwigBundle] Move the hinclude key away from templating#30959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#30874
LicenseMIT
Doc PRto do when pr is validated.

Maybe I shouldn't move directly the config key from templating to the other, but since the templating component has been deprecated we may change this directly without deprecating that key alone, WDYT ?

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch fromc045b3d toe6dfc08CompareApril 7, 2019 08:51
@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch frome6dfc08 to2957e52CompareApril 7, 2019 10:31
@Simperfit
Copy link
ContributorAuthor

done@stof@fabpot

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from2957e52 to98c6732CompareApril 7, 2019 10:34
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 7, 2019
@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from98c6732 tof53edb0CompareApril 7, 2019 11:57
@Simperfit
Copy link
ContributorAuthor

Simperfit commentedApr 7, 2019 via email

It does work properly since I didnt removed anything I just added thedeprecationLe dim. 7 avr. 2019 à 18:53, Fabien Potencier <notifications@github.com> aécrit :
…
***@***.**** commented on this pull request. ------------------------------ In src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php <#30959 (comment)>: > @@ -487,6 +487,7 @@ private function registerFragmentsConfiguration(array $config, ContainerBuilder return; } + $container->setParameter('fragment.renderer.hinclude.global_template', $config['hinclude_default_template']); Does it work even when providing the value via the old key and not via the new one? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#30959 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8hOp9EZCqrgg-gnArTKIx-YNs2wCks5veiJvgaJpZM4cgo9l> .

@Simperfit
Copy link
ContributorAuthor

Simperfit commentedApr 7, 2019 via email

Ooow I understand, I will write one !Le dim. 7 avr. 2019 à 21:56, Robin Chalas <notifications@github.com> aécrit :
…
***@***.**** commented on this pull request. ------------------------------ In src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php <#30959 (comment)>: > @@ -487,6 +487,7 @@ private function registerFragmentsConfiguration(array $config, ContainerBuilder return; } + $container->setParameter('fragment.renderer.hinclude.global_template', $config['hinclude_default_template']);@Simperfit <https://github.com/Simperfit> You are setting a parameter with no prior existence/emptiness check at 2 different places so only one can win (and potentially not the expected one). We need a test I guess :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30959 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8gQ9gFaNNDHFMwT6HHFKttPRNSDgks5vek1egaJpZM4cgo9l> .

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch fromf53edb0 to0a0d913CompareApril 8, 2019 06:04
@Simperfit
Copy link
ContributorAuthor

I've added an existence check to not replace if it has been already setted.

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from3c89d11 to2ee4331CompareApril 8, 2019 07:41
@Simperfit
Copy link
ContributorAuthor

@fabpot Should be ok now, I've added a test.

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from2ee4331 to400ed9aCompareApril 8, 2019 08:10
@Simperfit
Copy link
ContributorAuthor

@fabpot PR ready, CI failure not related to this PR.

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from400ed9a to7fb7329CompareApril 8, 2019 10:55
@Simperfit
Copy link
ContributorAuthor

done@fabpot

@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from7fb7329 to2dfcc51CompareApril 8, 2019 10:56
@SimperfitSimperfitforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from2dfcc51 to9b605e9CompareApril 8, 2019 11:17
@Simperfit
Copy link
ContributorAuthor

done@fabpot

@fabpotfabpotforce-pushed thefeature/remove-hinclude-from-templating-and-give-it-to-fragments branch from9b605e9 to4f39339CompareApril 8, 2019 14:09
@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit4f39339 intosymfony:masterApr 8, 2019
fabpot added a commit that referenced this pull requestApr 8, 2019
…way from templating (Simperfit)This PR was squashed before being merged into the 4.3-dev branch (closes#30959).Discussion----------[FrameworkBundle] [TwigBundle] Move the hinclude key away from templating| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#30874 <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | to do when pr is validated.<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Maybe I shouldn't move directly the config key from templating to the other, but since the templating component has been deprecated we may change this directly without deprecating that key alone, WDYT ?Commits-------4f39339 [FrameworkBundle] [TwigBundle] Move the hinclude key away from templating
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@Simperfit@fabpot@nicolas-grekas@stof@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp